Skip to content

test(patch): use get instead of the removed download alias - #1600

Open
Mikola Lysenko (mikolalysenko) wants to merge 1 commit into
mainfrom
socket-patch-v5-migrate-download
Open

Mikola Lysenko (mikolalysenko) wants to merge 1 commit into
mainfrom
socket-patch-v5-migrate-download

Conversation

@mikolalysenko

@mikolalysenko Mikola Lysenko (mikolalysenko) commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

LLM Description written by Claude Code:claude-opus-5-5

socket-patch v5 removes the download alias of get (SocketDev/socket-patch#966, implemented in SocketDev/socket-patch#1031). In v5 the old spelling is a usage error (exit 2).

test/integration/binary/js.test.mts ran socket patch download --dry-run ... express and accepted any exit code (toBeGreaterThanOrEqual(0)), so it could not catch a broken command. The test now:

  • runs socket patch get --dry-run --config {} express;
  • requires exit code 0;
  • requires the dry-run preview on stderr to show Arguments: get express, which proves cmd-patch forwards the right subcommand to socket-patch.

The new spelling also works with the socket-patch v2.0.0 binary this repo bundles today, because get is the primary command name in every version.

Testing: I did not run the integration suite locally, because pnpm install here fails on this checkout's pnpm and corepack settings. CI runs the test under RUN_INTEGRATION_TESTS.

🤖 Generated with Claude Code


Note

Low Risk
Test-only change with stricter assertions; no production code or runtime behavior is modified.

Overview
Updates the JS binary integration dry-run test to call socket patch get instead of the removed patch download alias (socket-patch v5 treats download as a usage error).

The test now requires exit code 0 (replacing a loose >= 0 check that could pass on failure) and asserts stderr includes Arguments: get express, so dry-run proves the patch subcommand forwards get correctly to socket-patch.

Reviewed by Cursor Bugbot for commit 115d9eb. Configure here.

socket-patch v5 removes the `download` alias of `get`. Call
`patch get` in the dry-run integration test, and check that the
command exits 0 and forwards `get express` to socket-patch. The
old check accepted any exit code, so a usage error also passed.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant