Repository navigation
test(patch): use get instead of the removed download alias - #1600
Open
Mikola Lysenko (mikolalysenko) wants to merge 1 commit into
Open
Mikola Lysenko (mikolalysenko) wants to merge 1 commit into
Mikola Lysenko (mikolalysenko) wants to merge 1 commit into
Conversation
socket-patch v5 removes the `download` alias of `get`. Call `patch get` in the dry-run integration test, and check that the command exits 0 and forwards `get express` to socket-patch. The old check accepted any exit code, so a usage error also passed.
4 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLM Description written by Claude Code:claude-opus-5-5
socket-patch v5 removes the
downloadalias ofget(SocketDev/socket-patch#966, implemented in SocketDev/socket-patch#1031). In v5 the old spelling is a usage error (exit 2).test/integration/binary/js.test.mtsransocket patch download --dry-run ... expressand accepted any exit code (toBeGreaterThanOrEqual(0)), so it could not catch a broken command. The test now:socket patch get --dry-run --config {} express;Arguments: get express, which provescmd-patchforwards the right subcommand to socket-patch.The new spelling also works with the socket-patch v2.0.0 binary this repo bundles today, because
getis the primary command name in every version.Testing: I did not run the integration suite locally, because
pnpm installhere fails on this checkout's pnpm and corepack settings. CI runs the test underRUN_INTEGRATION_TESTS.🤖 Generated with Claude Code
Note
Low Risk
Test-only change with stricter assertions; no production code or runtime behavior is modified.
Overview
Updates the JS binary integration dry-run test to call
socket patch getinstead of the removedpatch downloadalias (socket-patch v5 treatsdownloadas a usage error).The test now requires exit code 0 (replacing a loose
>= 0check that could pass on failure) and asserts stderr includesArguments: get express, so dry-run proves the patch subcommand forwardsgetcorrectly to socket-patch.Reviewed by Cursor Bugbot for commit 115d9eb. Configure here.