Skip to content

Route the remaining hand-rolled child-process deadlines through utils::process #1067

Open
Open
Route the remaining hand-rolled child-process deadlines through utils::process#1067
Labels
agent:triagedarch-auditFiled by a scheduled architecture audit routine (see the architecture review discussion)priority:p3refactorStructural change: duplicated code or logic, missing abstraction, layering, dead code

Description

@mikolalysenko
Mikola Lysenko (mikolalysenko)
opened on Oct 7, 2026

[agent] Filed by the October 7 architecture audit campaign (core). Register: arch-audit register.

Kind: refactor. Source: C48 remainder (#845 closed by #886 slice 1), register C48.

Problem: #886 added utils::process::output_within (10 s probe deadline) and closed #845, but hand-rolled spawn deadlines remain: pdm_site.rs#L19 keeps its own 5 s PROBE_TIMEOUT with tokio::time::timeout and kill_on_drop (added by #611), and npm_dir.rs#L426 and #L1220-L1225 keep 30 s and 60 s git exchanges. The async CommandRunner and the architecture guard from #886's plan were never tracked.

Impact: probe deadlines and kill policy drift again; the refactor notes forbid new timeout + kill_on_drop sites but nothing enforces it.

Proposed change: route pdm_site and the npm_dir git exchange through the shared runner (an async variant if needed) and delete the local deadlines; add an architecture test that rejects new kill_on_drop spawns outside utils::process.

Acceptance criteria:

  • No tokio::time::timeout around a child process outside utils::process.
  • PDM and npm_dir suites green; the guard test fails on a planted site.

Dependencies: none.

Generated by Claude Code

Activity

  1. Mikola Lysenko (mikolalysenko)
    added
    arch-auditFiled by a scheduled architecture audit routine (see the architecture review discussion)
    refactorStructural change: duplicated code or logic, missing abstraction, layering, dead code
    on Oct 7, 2026

  2. mikolalysenko commented on Oct 7, 2026

    @mikolalysenko
    Mikola Lysenko (mikolalysenko)
    on Oct 7, 2026
    CollaboratorAuthor

    [agent] Triage: priority:p3 (cross-cutting refactor). No duplicate or open PR found.

    Generated by Claude Code

  3. Mikola Lysenko (mikolalysenko)
    added
    agent:triaged
    priority:p3
    on Oct 7, 2026

  4. mikolalysenko commented on Oct 8, 2026

    @mikolalysenko
    Mikola Lysenko (mikolalysenko)
    on Oct 8, 2026
    CollaboratorAuthor

    [agent] Claiming this issue for the architecture refactor routine (highest leverage: the only refactor slice whose files no open PR changes; routes the PDM site probe through utils::process::output_within and adds the guard). Branch: arch-refactor/1067-pdm-probe-deadline. Claim-ID: 2026-10-08T02:56:01Z-9ee976

    Slice taken: crawlers/python_crawler/pdm_site.rs plus a guard test that rejects new kill_on_drop spawns outside utils::process, with vendor/npm_dir.rs on its pending list. The npm_dir git exchange remains for a later slice, because #1026 changes npm_dir.rs and utils/process.rs.

    Generated by Claude Code

  5. Mikola Lysenko (mikolalysenko)
    added
    agent:claimed
    on Oct 8, 2026

  6. mikolalysenko commented on Oct 8, 2026

    @mikolalysenko
    Mikola Lysenko (mikolalysenko)
    on Oct 8, 2026
    CollaboratorAuthor

    [agent] Draft PR for the pdm_site slice: #1106.

    Generated by Claude Code

  7. Mikola Lysenko (mikolalysenko)
    added 2 commits that reference this issue on Oct 8, 2026

    Bound the PDM site probe through utils::process

    7ec4ec7

    Refactor run: #1106 for #1067 (C48)

    3ac0495

  8. mikolalysenko commented on Oct 11, 2026

    @mikolalysenko
    Mikola Lysenko (mikolalysenko)
    on Oct 11, 2026
    CollaboratorAuthor

    [agent] Janitor: releasing the stale claim Claim-ID: 2026-10-08T02:56:01Z-9ee976. Its PR #1106 merged on 2026-10-08 as the pdm_site slice only; the vendor/npm_dir.rs git exchange still has a hand-rolled deadline. No follow-up PR exists and the claimer has been silent since 2026-10-08 03:01Z. The issue stays open and any fixer can claim it.

    Generated by Claude Code

  9. Mikola Lysenko (mikolalysenko)
    removed
    agent:claimed
    on Oct 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent:triagedarch-auditFiled by a scheduled architecture audit routine (see the architecture review discussion)priority:p3refactorStructural change: duplicated code or logic, missing abstraction, layering, dead code

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions