Repository navigation
Run 2 of 4 Gradle hosted Windows cells on PRs - #1353
Closed
Mikola Lysenko (mikolalysenko) wants to merge 3 commits into
Closed
Mikola Lysenko (mikolalysenko) wants to merge 3 commits into
Mikola Lysenko (mikolalysenko) wants to merge 3 commits into
Conversation
Each matching PR ran the 43-test hosted Gradle suite on Windows four times, once per Gradle line, at 28-42 min a cell: about 70% of the workflow's Windows minutes and its wall clock. Keep the oldest (6.9.4) and newest (9.8.0) lines on PRs and leave 7.6.6 and 8.14.3 hosted on Windows to the nightly and manual runs. ci.yml's e2e still runs hosted on all four lines on ubuntu on every PR and in the merge queue. Fixes #1300. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VrgiQoDwt3vjxG2zNfZBAA
Collaborator
Author
|
bugbot run Generated by Claude Code |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 2418944. Configure here.
hosted-e2e (and the other live minimist suites) fail on every head: production now serves minimist@1.2.2 patch 642d7f02 while the tests pin 80630680 (#1293). This is #1301's change, applied verbatim; it becomes a no-op once #1301 lands. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VrgiQoDwt3vjxG2zNfZBAA
Collaborator
Author
Mikola Lysenko (mikolalysenko)
enabled auto-merge
October 9, 2026 17:45
Tanmay Singla (Tanmay182003)
approved these changes
Oct 9, 2026
Mikola Lysenko (mikolalysenko)
disabled auto-merge
October 9, 2026 18:02
Mikola Lysenko (mikolalysenko)
enabled auto-merge
October 9, 2026 18:03
Collaborator
Author
|
Ready for review at
Labeled Generated by Claude Code |
Mikola Lysenko (mikolalysenko)
removed this pull request from the merge queue due to a manual request
Oct 9, 2026
Collaborator
Author
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1300
Problem
Every PR that matches
gradle-compatibility.yml'spaths:(~60–100 full runs/day) runs the 43-test hosted Gradle suite on Windows four times, once per Gradle line. Baseline run 37960054571 (2026-10-09 16:34):The 4 hosted cells are 132 of the ~189 Windows job-min (70%), and the 8.14.3 cell sets the wall clock. None failed on a PR in the windows sampled by #1300 / #1177 / #1255.
Change
Two
excludeentries incells, keyed on the event like the existing macOS/ubuntu ones: onpull_requestonly, skipwindows-latest × {7.6.6, 8.14.3} × hosted. Onschedule/workflow_dispatchtheosvalue is'', which matches no cell, so the nightly grid is still the full 36 cells. Header comment updated.Expected saving
ci-ok,clippyor the merge queue: this workflow doesn't run inmerge_group.Measured result
This PR's run 37970547476 (head 3edc241, success) vs baseline 37960054571:
excludematches as intended. This run also ran the ubuntuextras(the PR touches the workflow file, sogradle_core=true). Those aren't in the baseline and don't change the Windows comparison.merge_grouptrigger).Where each moved test still runs
17 4 * * *) andworkflow_dispatchofgradle-compatibility.yml.e2eon every PR and in the merge queue (unchanged).Risk
A regression that hits only Windows and only hosted mode on the middle two Gradle lines would surface in the next nightly instead of on the PR. No test, assertion or required check changes. Local checks:
scripts/tests/test_ci_e2e_tiers.py+test_ci_gradle_prefixes.pypass (33 tests);zizmorandactionlintreport the same findings as on main (pre-existing).🤖 Generated with Claude Code
https://claude.ai/code/session_01VrgiQoDwt3vjxG2zNfZBAA
Generated by Claude Code