Delete the dead lock_inventory::wired_vendor_integrity reader (#782)

[Mikola Lysenko (mikolalysenko)]

LLM Description written by Claude Code:claude-opus-5-5

Refs #782 (the #801 slice; the tracking issue keeps the rest).

Summary

Delete vendor::lock_inventory::wired_vendor_integrity (lock_inventory/wired.rs). It read the integrity a rewired lock records for a vendored artifact, for package-lock/shrinkwrap, pnpm, yarn classic and berry, bun.lock, bun.lockb and the Python locks. Nothing in the workspace calls it outside its own tests, so it was a sixth lock reader that looked live and had to be kept in step with the real entry walks.

Why (leverage)

• Issue: #782, consolidated scope from Delete lock_inventory::wired_vendor_integrity and PnpmLock::wired_integrity, which have no production caller #801. Register row E41 (discussion #560), living document doc/06-discovery-vex.md.
• B 0, U 0, D ≈2.3 (≈−220 production lines, one duplicate reader of six lock formats), S 0, R L. Score ≈4.6. It was the top candidate whose files no open PR changes, now that Fix yarn classic empty-range lock keys (#1271) #1274 freed lock_inventory/tests.rs. The larger candidates (manifest-load cluster An unparseable .socket/manifest.json is reported under five different --json error codes depending on the command #931/apply, apply --check and vendor report noManifest (exit 0) when .socket/manifest.json exists but can't be stat'd #998/scan reads a corrupt manifest as empty, so --prune skips GC and reports success #1063/A directory at .socket/manifest.json exits 2 with no --json output when --manifest-path spells the path, but exits 1 with manifest_unreadable under the default path #1123, Vendored requirements.txt refuses a six (==1.16.0) pin that the inventory and hosted mode accept, because exact pins are read by three grammars #1365) are still held by open fixer PRs.

What changed

• vendor/lock_inventory/wired.rs: deleted.
• vendor/lock_inventory/mod.rs: mod wired, the pub use re-export and the module-doc line that said repair reads it are gone.
• vendor/lock_inventory/tests.rs: the 5 tests that exercised only wired_vendor_integrity are deleted. fifo_lockfiles_fail_fast_instead_of_wedging and bun_dangling_text_lock_link_leaves_the_binary_lock_live keep all their other assertions and drop just the wired one.
• vex/discover/bun.rs: module doc no longer names it as a second user of the bun lock gate.

Not in this slice, because open PRs change those files: PnpmLock::wired_integrity and its test (formats/pnpm/mod.rs, #1320), the doc line in utils/python_lock.rs (#1332), and the "wired_vendor_integrity(" needle in the vex/discover/mod.rs forbidden-reader guard (#1321, #1349). The needle is still harmless, since the guard forbids a name that no longer exists.

Deleted (git diff --numstat origin/main)

• Production: +3 / −224 (wired.rs −220, mod.rs +1/−5, bun.rs +2/−2).
• Tests: +4 / −256 (tests.rs +4/−216, wired.rs test module −40).

Behavior

None. No production code called the function; the CLI and node crates never referenced it.

Test evidence

• cargo clippy --workspace --all-features -- -D warnings: clean, so nothing it used became dead code.
• cargo test -p socket-patch-core --lib: 6096 passed, 4 failed. The 4 are the root-sandbox permission tests that fail on main too (copy_tree::relax_loop_must_not_traverse_symlinked_root, vlt_heal::an_unremovable_hidden_lock_keeps_every_store_entry, pypi_poetry::wire_write_failure_maps_error_and_leaves_lock_untouched, pypi_requirements::wire_failure_rolls_back_already_written_files); CI runs unprivileged.
• cargo test -p socket-patch-core --lib lock_inventory: 142 passed.
• rustfmt --check on the touched files: clean (tests.rs was clean on main and is reformatted after the tuple shrank).

Risk

Low. It only deletes code; the compiler and clippy prove nothing else called it.

🤖 Generated with Claude Code

https://claude.ai/code/session_01XNXgguh8iNycd4sv7u5cPe

---

Note

Low Risk
Pure deletion of uncalled code; clippy and existing tests confirm no remaining callers.

Overview
Removes the unused wired_vendor_integrity lock reader (~220 lines in lock_inventory/wired.rs), which duplicated integrity lookups across npm-family, yarn, bun, and Python locks after repair stopped calling it.

lock_inventory/mod.rs drops the wired submodule, its re-export, and module docs that tied repair to that API. lock_inventory/tests.rs deletes five tests dedicated to wired_vendor_integrity and trims related assertions from FIFO and Bun #735 tests. vex/discover/bun.rs doc comment no longer lists it beside bun_workspace for the text-vs-binary lock gate.

No runtime behavior change: nothing outside those tests referenced the function.

^{Reviewed by Cursor Bugbot for commit 392bc1f. Configure here.}

[Mikola Lysenko (mikolalysenko)]

BugBot review

---

Generated by Claude Code

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 392bc1f. Configure here.}

[Mikola Lysenko (mikolalysenko)]

[agent] ci-ok failed because every job in CI run 37985510178 was cancelled before any test body ran. No newer run replaced it, so this was not concurrency supersession and has nothing to do with the diff. I re-ran it once. Locally: workspace clippy is clean, and the core lib tests pass apart from the 4 root-sandbox permission tests that also fail on main.

---

Generated by Claude Code