Repository navigation
Keep browser smoke tests from rewriting tracked screenshots by default #46
Description
PR #45 exposed a separate browser-test maintenance issue: running make ci-local / the browser smoke path can rewrite tracked screenshot baselines such as screenshots/rail-timeline-narrow.png.
The attempted cleanup in #45 used a pre-push hook to restore screenshots after CI, but the underlying problem should be handled in the browser test workflow instead. Validation commands should not leave tracked screenshot files modified.
Expected direction:
- Browser smoke tests should write transient screenshots to an untracked temp/artifact path, or compare against baselines without mutating them.
- Intentional baseline refreshes should use an explicit update command or documented maintainer flow.
make ci-localshould finish with a clean worktree when there is no intentional visual change.- Any fix should avoid Git hooks or post-test commands that reset tracked files behind the contributor's back.
Related: #45
Activity
fix(test): keep browser screenshots out of tracked baselines
blackopsrepl commentedon May 13, 2026
Fixed by #47, which moves ordinary browser smoke screenshots to
target/browser-smoke/screenshots/and keeps trackedscreenshots/refreshes behind the explicitmake screenshots-updatemaintainer flow.Closing this as resolved. @benabel, please rebase #45 on current
mainand drop the.pre-commit-config.yamlscreenshot cleanup hook now that the browser test workflow fix has landed.fix(test): keep browser screenshots out of tracked baselines
feat(build): add TypeScript for dev-only type checking (#45)