Skip to content

fix(plugins): offer export formats the plugin manifest lists - #3515

Merged
datlechin merged 2 commits into
mainfrom
fix/plugin-catalog-from-manifest
Oct 18, 2026
Merged

datlechin merged 2 commits into
mainfrom
fix/plugin-catalog-from-manifest

Conversation

@datlechin

@datlechin datlechin commented Oct 18, 2026 •

Copy link
Copy Markdown
Member

Why

Change

  • RegistryPlugin decodes databaseTypeIds and exportFormatIds as required and drops iconName. The Export dialog's install offers come from exportFormatIds only, and the dialog now observes the registry client so a late manifest fetch shows them (plugins-1).
  • The Export menu label is the plugin's name: "Install Parquet Export…" instead of "Install Parquet…".
  • A rejected plugin's icon comes from the curated snapshot of its primary type id, through one helper shared with the lazy plugin row (plugins-2).
  • Fragment for feat(plugins): read the v3 plugin manifest from updates.tablepro.app #3503, which removed the com.TablePro.customRegistryURL setting without one.

Verified

  • ExportFormatCatalogTests, PluginLazyRegistrationTests (new icon case), RegistryReleaseSelectionTests, PluginRegistryUpdatePassTests, RegistryClientFreshnessTests, DriverUnavailabilityTests pass. The hand-Parquet test became "no manifest offers no install"; the JSON fixtures gained exportFormatIds.

Not in this PR

@datlechin
datlechin merged commit 1e100a8 into main Oct 18, 2026
8 checks passed
@datlechin
datlechin deleted the fix/plugin-catalog-from-manifest branch October 18, 2026 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant