Repository navigation
refactor(linux): conventional Cargo manifests and module files - #3533
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Linux workspace wrote Cargo defaults out by hand, gave every member its own path to each internal crate, named the driver libs
drivers_<x>apart from their packages, and used two module layouts.Change
tablepro_driver_<x>).[lib],[[bin]]and[[test]]keys that restate defaults are gone;publish.workspace = true;resolver = "3".rustixare declared once in[workspace.dependencies]. Dev-dependencies that repeat a normal one are dropped.Cargo.lockis unchanged.foo.rsplusfoo/modules becomefoo/mod.rs, held byclippy::self_named_module_files.ui/export_dialog.rsmoves toui/export/dialog.rs, and three*_tests.rsfiles becometestssubmodules.meson_options.txtis nowmeson.options; rustfmt drops the defaultuse_small_heuristics.Verified
In ubuntu:26.04: fmt check, clippy with and without default features, meson compile and dist, all 7 meson test suites under xvfb, cargo shear, the docs check.