Repository navigation
feat(table-core): Further improve tree-shaking across features - #6626
Open
KevinVandy wants to merge 1 commit into
Open
KevinVandy wants to merge 1 commit into
KevinVandy wants to merge 1 commit into
Conversation
Keep column ordering, column pinning, and row expanding code out of the core bundle, route more cross-feature reads through feature stubs, and stop allocating unused onAfterUpdate wrappers in production memos. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: ab37dd3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit ab37dd3
☁️ Nx Cloud last updated this comment at |
Contributor
🚀 Changeset Version Preview2 package(s) bumped directly, 15 bumped as dependents. 🟩 Patch bumps
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (22)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughCore utilities now use shared fallbacks for optional column and row features. Column ordering, pinning, visibility, and row expansion call these helpers. The changes also update callback and warning handling, column-size calculations, and devtools bundle measurements. ChangesOptional-feature tree-shaking and bundle data
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Refactor Merge Risk: ⚪ Minimal · up to This change reduces bundle size by moving optional feature code behind shared fallbacks. Behavior is intended to stay the same, and the new tests cover the pinned-region total-size and leaf-column ordering paths. No merge-blocking risk was identified. Pre-merge checks |
  |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check |  |
The description gives a detailed and relevant summary of the implementation, performance results, bundle-size changes, and follow-up notes. It does not include the required Changes, Checklist, or Rele… | Add the repository template sections. Include the Changes section, complete each Checklist item, and confirm whether the change affects published code and whether a changeset was generated. Also state the test commands run or explain why th… |
✅ Passed checks (4 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly and concisely describes the primary change: further tree-shaking improvements across table-core features. |
| Docstring Coverage | |
Docstring coverage is 80.85% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 47 functions across 20 files. (2 skipped: 2… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Description check
Explanation
The description gives a detailed and relevant summary of the implementation, performance results, bundle-size changes, and follow-up notes. It does not include the required Changes, Checklist, or Release Impact sections, and it does not confirm the required testing, contributing-guide review, AI-assisted code review, or changeset status.
Resolution
Add the repository template sections. Include the Changes section, complete each Checklist item, and confirm whether the change affects published code and whether a changeset was generated. Also state the test commands run or explain why they do not apply.
- Fix all pre-merge checks with AI
✨ Finishing Touches
📝 Generate docstrings
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
- Commit to this branch
- Create a new PR
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
core/featureStubs.ts(orderLeafColumns,orderByColumnPinning,expandRowModel) call a function that column grouping, column pinning, or row expanding stores on the table ininitTableInstanceData, the same way_aggregateColumnValueworks.constructTabledrops from 5.51 to 5.24 kB brotli, and a minimal ReactuseTablefrom 8.49 to 8.21 kB.features/column-pinning/orderByColumnPinning.ts. It replaces the separate copies in core header groups,row_getVisibleCells, and cell selection's column order.tableMemono longer gives each memo anonAfterUpdatewrapper when there is no callback. Creating 500k row memos used 289 MB of heap instead of 389 MB and ran about 20% faster.process.env.NODE_ENVat each dev warning, so production builds drop the message strings.Notes
_orderByColumnPinning,_orderGroupedColumns, and_expandRowsare untyped private functions stored on the table behind@ts-ignore. Together they account for about 270 B of the core saving. Replacing them with public APIs or static imports is a possible follow-up.🤖 Generated with Claude Code
Summary by CodeRabbit