fix(examples): Pass octane e2e on octane 0.12 by KevinVandy · Pull Request #6630 · TanStack/table

KevinVandy · 2026-10-10T03:18:52Z

Fixes the octane e2e failures on main after #6627 (failed run).

Octane examples and docs use colspan / rowspan instead of colSpan / rowSpan. Octane 0.12's DEV diagnostics don't list colSpan or rowSpan as known DOM props, so every header row logged "Octane does not recognize the colSpan prop", which fails the smoke tests' console-error checks. Octane accepts the native lowercase names. The test fixture in octane-table gets the same change.
basic-external-atoms and basic-external-state smoke tests wait one microtask after a scripted click before reading the DOM. Octane 0.12 commits a click's updates in the microtask after the event.

All 33 octane examples pass test:e2e locally (137 tests).

Notes

React accepts colSpan, so the missing entry is probably an Octane bug; it isn't in octane's main either. Once Octane fixes it, the camelCase spelling would work again.

🤖 Generated with Claude Code

Summary by CodeRabbit

Documentation
- Updated table-spanning examples to use lowercase colspan and rowspan attributes.
Bug Fixes
- Updated Octane examples to render table cell spans with lowercase HTML attributes.
- Adjusted timing checks in external state and atom examples to read results after click updates settle.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

changeset-bot · 2026-10-10T03:18:58Z

⚠️ No Changeset found

Latest commit: 245c35a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-10-10T03:19:02Z

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository: TanStack/table/.coderabbit.yaml
Review profile: CHILL
Plan: Advanced
Run ID: a57593ba-e7da-45e0-b0c3-b776e773ef91

📥 Commits

Reviewing files that changed from the base of the PR and between 47733cb and 245c35a.

📒 Files selected for processing (37)

docs/framework/octane/guide/cell-spanning.md
docs/framework/octane/guide/column-resizing.md
docs/framework/octane/guide/expanding.md
examples/octane/aggregation/src/main.tsrx
examples/octane/basic-dynamic-columns/src/main.tsrx
examples/octane/basic-external-atoms/src/main.tsrx
examples/octane/basic-external-atoms/tests/e2e/smoke.spec.ts
examples/octane/basic-external-state/src/main.tsrx
examples/octane/basic-external-state/tests/e2e/smoke.spec.ts
examples/octane/basic-subscribe/src/main.tsrx
examples/octane/cell-spanning/src/main.tsrx
examples/octane/column-ordering/src/main.tsrx
examples/octane/column-pinning-split/src/main.tsrx
examples/octane/column-pinning-sticky/src/main.tsrx
examples/octane/column-pinning/src/main.tsrx
examples/octane/column-resizing-performant/src/main.tsrx
examples/octane/column-resizing/src/main.tsrx
examples/octane/column-sizing/src/main.tsrx
examples/octane/column-visibility/src/main.tsrx
examples/octane/composable-tables/src/main.tsrx
examples/octane/custom-plugin/src/main.tsrx
examples/octane/expanding/src/main.tsrx
examples/octane/filters-faceted-bucketed/src/main.tsrx
examples/octane/filters-faceted/src/main.tsrx
examples/octane/filters-fuzzy/src/main.tsrx
examples/octane/filters/src/main.tsrx
examples/octane/grouped-aggregation/src/main.tsrx
examples/octane/grouping/src/main.tsrx
examples/octane/header-groups/src/main.tsrx
examples/octane/kitchen-sink/src/main.tsrx
examples/octane/pagination/src/main.tsrx
examples/octane/realtime-trading/src/table/TradingTable.tsrx
examples/octane/row-pinning/src/main.tsrx
examples/octane/row-selection/src/main.tsrx
examples/octane/sorting/src/main.tsrx
examples/octane/sub-components/src/main.tsrx
packages/octane-table/tests/_fixtures/features.tsrx

 _____________________________________________________________________
< This is 'temporary' in the same way legacy systems are 'temporary'. >
 ---------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).

✨ Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

nx-cloud · 2026-10-10T03:19:18Z

View your CI Pipeline Execution ↗ for commit 245c35a

Command	Status	Duration	Result
`nx affected --targets=test:eslint,test:sherif,t...`	✅ Succeeded	6m 22s	View ↗
`nx run-many --targets=build --exclude=examples/**`	✅ Succeeded	41s	View ↗

☁️ Nx Cloud last updated this comment at 2026-10-10 03:26:32 UTC

github-actions · 2026-10-10T03:19:52Z

🚀 Changeset Version Preview

1 package(s) bumped directly, 0 bumped as dependents.

🟨 Minor bumps

Package	Version	Reason
`@tanstack/octane-table`	9.2.8 → 9.3.0	Changeset

pkg-pr-new · 2026-10-10T03:23:21Z

More templates

@tanstack/alpine-table

npm i https://pkg.pr.new/@tanstack/alpine-table@6630

@tanstack/angular-table

npm i https://pkg.pr.new/@tanstack/angular-table@6630

@tanstack/angular-table-devtools

npm i https://pkg.pr.new/@tanstack/angular-table-devtools@6630

@tanstack/ember-table

npm i https://pkg.pr.new/@tanstack/ember-table@6630

@tanstack/lit-table

npm i https://pkg.pr.new/@tanstack/lit-table@6630

@tanstack/match-sorter-utils

npm i https://pkg.pr.new/@tanstack/match-sorter-utils@6630

@tanstack/octane-table

npm i https://pkg.pr.new/@tanstack/octane-table@6630

@tanstack/preact-table

npm i https://pkg.pr.new/@tanstack/preact-table@6630

@tanstack/preact-table-devtools

npm i https://pkg.pr.new/@tanstack/preact-table-devtools@6630

@tanstack/react-table

npm i https://pkg.pr.new/@tanstack/react-table@6630

@tanstack/react-table-devtools

npm i https://pkg.pr.new/@tanstack/react-table-devtools@6630

@tanstack/solid-table

npm i https://pkg.pr.new/@tanstack/solid-table@6630

@tanstack/solid-table-devtools

npm i https://pkg.pr.new/@tanstack/solid-table-devtools@6630

@tanstack/svelte-table

npm i https://pkg.pr.new/@tanstack/svelte-table@6630

@tanstack/table-core

npm i https://pkg.pr.new/@tanstack/table-core@6630

@tanstack/table-devtools

npm i https://pkg.pr.new/@tanstack/table-devtools@6630

@tanstack/vue-table

npm i https://pkg.pr.new/@tanstack/vue-table@6630

@tanstack/vue-table-devtools

npm i https://pkg.pr.new/@tanstack/vue-table-devtools@6630

commit: 245c35a

fix(examples): Pass octane e2e on octane 0.12

245c35a

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

KevinVandy marked this pull request as ready for review October 10, 2026 03:22

KevinVandy merged commit 6fc0005 into main Oct 10, 2026
9 of 10 checks passed

KevinVandy deleted the fix/octane-colspan branch October 10, 2026 03:33

KevinVandy mentioned this pull request Oct 10, 2026

chore: use the official TanStack Pacer, Hotkeys, and Table adapters octanejs/octane#1965

Draft

11 of 12 tasks

Navigation Menu

Repository navigation

fix(examples): Pass octane e2e on octane 0.12 - #6630

fix(examples): Pass octane e2e on octane 0.12#6630
KevinVandy merged 1 commit into
mainfrom
fix/octane-colspan

KevinVandy commented Oct 10, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

changeset-bot Bot commented Oct 10, 2026

Uh oh!

coderabbitai Bot commented Oct 10, 2026 •

edited

Loading

Uh oh!

nx-cloud Bot commented Oct 10, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 10, 2026

Uh oh!

pkg-pr-new Bot commented Oct 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

KevinVandy commented Oct 10, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Notes

Summary by CodeRabbit

Uh oh!

changeset-bot Bot commented Oct 10, 2026

⚠️ No Changeset found

Uh oh!

coderabbitai Bot commented Oct 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nx-cloud Bot commented Oct 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 10, 2026

🚀 Changeset Version Preview

🟨 Minor bumps

Uh oh!

pkg-pr-new Bot commented Oct 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

KevinVandy commented Oct 10, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Oct 10, 2026 •

edited

Loading

nx-cloud Bot commented Oct 10, 2026 •

edited

Loading