Repository navigation
Conversation
|
New warnings found with rstcheck: |
|
New unreachable files found with check_files.py: |
StaticRocket
left a comment
There was a problem hiding this comment.
This feels like it will be blocked by #740 as well, though the user did not tag the commits.
Additionally, review https://github.com/TexasInstruments/processor-sdk-doc?tab=contributing-ov-file#commit-types
There was a problem hiding this comment.
Acronyms are not allowed here
There was a problem hiding this comment.
Removed. accept.txt now only adds [Ss]ubgraphs?, logits?, perfsim and venv, which are the only entries Vale flagged. No acronyms.
| ********************************************* | ||
| AM62D Audio AI Software Developer's Guide | ||
| ********************************************* | ||
|
|
There was a problem hiding this comment.
There was a problem hiding this comment.
Done. The index title now uses #### (Section 1), and all pages follow the heading hierarchy in the contributing guide, with each adornment matching its title length.
| Introduction & Overview | ||
| ####################### | ||
|
|
||
| .. |tm| unicode:: U+2122 |
There was a problem hiding this comment.
Our IT department is stupid so you can't access this link internally, but:
https://docutils.sourceforge.io/docs/ref/rst/definitions.html
There was a problem hiding this comment.
Thanks. Replaced the custom .. |tm| unicode:: U+2122 with .. include:: <isonum.txt> and |trade| in all four edgeai pages.
| ******************** | ||
| Reference models | ||
| ******************** | ||
|
|
There was a problem hiding this comment.
Fixed. Every over/underline in the edgeai pages now has exactly the same length as its title.
|
|
||
| The end-to-end path is the same for a reference model or your own model: | ||
|
|
||
| #. **Obtain an ONNX model** — a reference graph shipped with the AudioAI ModelZoo, |
There was a problem hiding this comment.
Replaced the em dashes and the division sign with ASCII (- and /). The edgeai .rst files are now ASCII-only.
| into a dedicated Python 3.10 environment. The TIDL tools target Python 3.10. | ||
| These steps assume `pyenv <https://github.com/pyenv/pyenv>`__. | ||
|
|
||
| **1. Clone the repository** (|__TIDLRUNNER_REPO_URL__|): |
There was a problem hiding this comment.
Converted the hand-numbered steps to #. autonumbered lists, here and in model_zoo.rst.
| .. code-block:: console | ||
|
|
||
| $ git clone https://github.com/TexasInstruments/edgeai-tidlrunner.git | ||
| $ cd edgeai-tidlrunner |
There was a problem hiding this comment.
Indent content to fall under respective list item
There was a problem hiding this comment.
Done. Each step's paragraphs, code blocks and table are now indented 3 spaces under their list item.
| OS = os.environ.get("OS", "") | ||
|
|
||
| # Audio AI docs prefix every shell command with a "$ " prompt symbol; strip it | ||
| # from the copy-button output so copied text is directly runnable. |
There was a problem hiding this comment.
Just use a global regex definition: https://sphinx-copybutton.readthedocs.io/en/latest/use.html#using-regexp-prompt-identifiers
There was a problem hiding this comment.
I kept this scoped to the AM62DX edgeai build on purpose. A global copybutton_prompt_text would change copy behavior for every device doc.
There was a problem hiding this comment.
Nope, we are not pulling this
There was a problem hiding this comment.
Removed from the PR. The file is no longer tracked.
There was a problem hiding this comment.
Use an svg or a graphviz graph definition. We are not pulling in an electron app for building documentation.
There was a problem hiding this comment.
Removed from the PR. The file is no longer tracked.
StaticRocket
left a comment
There was a problem hiding this comment.
This feels like it will be blocked by #740 as well, though the user did not tag the commits.
Additionally, review https://github.com/TexasInstruments/processor-sdk-doc?tab=contributing-ov-file#commit-types
Signed-off-by: JuneChul Roh <jroh@ti.com>
Signed-off-by: JuneChul Roh <jroh@ti.com>
Signed-off-by: JuneChul Roh <jroh@ti.com>
Signed-off-by: JuneChul Roh <jroh@ti.com>
Signed-off-by: JuneChul Roh <jroh@ti.com>
Signed-off-by: JuneChul Roh <jroh@ti.com>
Signed-off-by: JuneChul Roh <jroh@ti.com>
…M62D setup Signed-off-by: JuneChul Roh <jroh@ti.com>
Audio AI docs prefix every shell command with "$ "; configure copybutton to strip it so copied text is directly runnable. Signed-off-by: JuneChul Roh <jroh@ti.com>
Signed-off-by: JuneChul Roh <jroh@ti.com>
…tion. Signed-off-by: JuneChul Roh <jroh@ti.com>
…l zoo URL Rename source/devices/AM62DX/audioai to edgeai and the AM62DX_audioai_* config files to AM62DX_edgeai_*. Point __MODELZOO_REPO_URL__ and the model zoo clone command to TexasInstruments/audioai-modelzoo. Signed-off-by: JuneChul Roh <jroh@ti.com>
Split into "Model Compile and Evaluate" (model_compile_evaluate.rst) and "Model Inspect" (model_inspect.rst). Update the toctree, the AM62DX edgeai toc config, labels, and cross-references in the other pages. Signed-off-by: JuneChul Roh <jroh@ti.com>
Signed-off-by: JuneChul Roh <jroh@ti.com>
Signed-off-by: JuneChul Roh <jroh@ti.com>
Trim the Vale vocabulary to the entries Vale needs, fix heading adornments and non-ASCII text, use isonum.txt and #. autonumbered steps, and replace the removed replacement variables with literal values. Signed-off-by: JuneChul Roh <jroh@ti.com>
9ac0c1e to
0f63803
Compare
|
@StaticRocket I have addressed most of your review comments. Please let me know if any further fix is required. Thanks! |
Summary
Adds a new Audio AI documentation set for AM62D (AM62DX). It builds with
DEVFAMILY=AM62DX OS=edgeai.What's included
New pages under
source/devices/AM62DX/edgeai/:Supporting changes:
configs/AM62DX/AM62DX_edgeai_{config,tags,toc}for the newedgeaiOS target.conf.pyupdate..github/styles/config/vocabularies/PSDK/accept.txt.source/images/audioai/(drawio, svg, png, export script).Testing
docker run -it --rm -v "$PWD":/build ghcr.io/texasinstruments/processor-sdk-doc:latest make DEVFAMILY=AM62DX OS=edgeaiNotes