Repository navigation
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
c09fdc7 to
9e8b706
Compare
|
Thanks for the detailed review. I have separated the shared persistence fixes from this desktop feature and rebuilt the proposal on that baseline.
The four safety notes are also covered: live primary/split drafts are captured before refresh; returning missing sources do not overwrite dirty drafts; Save As links receive watchers; and bulk removal persists exclusions before removing records. Regression tests cover success, cancellation, changing state during confirmation, persistence failure and partial folder operations. Additional related improvements include folder conversion/export, sidebar conversion using the existing HTML drag mechanism, less crowded source-path presentation, status-icon consistency and layout-independent saving. Remaining native atomicity limits are documented rather than represented as fully solved. If the desktop feature direction is not suitable for the project, I am happy to narrow or withdraw the feature proposal. The shared safety baseline is now proposed separately in #279; the description links the incremental Linked Workspace diff for easier review. |
Hi, I've been busy with a few things lately, so I haven't had enough time to review the code thoroughly. I requested a Copilot review in the meantime, but I don't fully rely on Copilot's reviews, as they aren't always accurate or reliable. I prefer to review the code myself before making any decisions. I've taken an initial look at the changes, and there are a few things I'd like to point out. However, I need a little more time to go through everything properly. I'll get back to you with my feedback as soon as possible. Thanks for your patience and understanding! |
Desktop Linked Workspace: original files, folder workflows and draft protection
This updates the reviewed Linked Workspace proposal with the requested hierarchy, actions and safety behavior. It depends on the separately proposed shared persistence/reliability changes; those are not presented as defects introduced by Linked Workspace.
User-facing behavior
file-symlink/folder-symlinkfor real linked sources, keeping normal Vault icons unchanged..mdwhen needed and proposes the document name. A Vault export keeps its Vault document and focuses the new linked document; a linked Save As keeps both linked documents.book-open-textfor both guides. Update only the Linked Workspace guide.Safety and failure handling
Platform and limits
Linked-source actions require desktop native APIs and are hidden/disabled in the web app, including Docker-served deployments. Browser recovery content remains usable without reconnecting local paths. Native development/manual evidence is Windows-based; macOS/Linux native behavior is not claimed verified.
This branch uses the official Neutralino 6.5.0 runtime/client pins. Standard external HTML file drops remain Vault-copy imports. Native path drops, single-instance integration and the experimental pointer fallback are proposed separately in draft #269.
Scan limits: 10,000 Markdown files, 40,000 entries, 2,000 directories, depth 32, 20 MiB per Markdown source, 200 MiB staged content and a 60-second scan budget. Recovery is not a backup. Native APIs do not provide an atomic compare-and-write/no-overwrite guarantee, so a race with another process cannot be completely eliminated by application-side checks.
Validation
Review dependency
Depends on shared safety/reliability PR #279. Because this cross-fork PR still targets upstream
main, its full diff currently includes that baseline. For the Linked Workspace-only changes, use the incremental comparison. After #279 merges, I will rebase onto the resulting upstream baseline.