Repository navigation
ci: latest CI update before 3.0.0 release - #4151
Conversation
There was a problem hiding this comment.
💡 Harness Review
The CI and release-metadata updates are broadly consistent, but the unified-test template now refers to a platform collection that the project metadata does not define.
Reviewed commit e24ed74
🤖 Helpful? 👍/👎
Corrections due to: 1) 'GhostBehaviour' is inaccessible due to its protection level 2) Inconsistent accessibility: property type 'NetcodeWorld' is less accessible than property 'NetworkManager.NetcodeWorld' etc
….test-framework dependency due to CoreCLR flag usage
| # already immutable, so there is nothing to pin against. | ||
| unified_editors: | ||
| default: | ||
| - 6000.7.0a5 |
There was a problem hiding this comment.
This was removed as it's covered by minimal editor now
| unified_netcode_version: 6.7.0 | ||
|
|
||
| # The unified job runs in Editor context only, so a single fast platform is enough. | ||
| unified_test_platforms: |
There was a problem hiding this comment.
Removed as it's the same as default test platform
|
/review |
There was a problem hiding this comment.
💡 Harness Review
The Unified CI matrix now consistently targets the default validation editor and platform, but its manifest swap leaves that job running against stale test-project package versions.
Reviewed commit 7c9716c
🤖 Helpful? 👍/👎
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop-3.x.x #4151 +/- ##
==============================================
Coverage 78.18% 78.18%
==============================================
Files 153 153
Lines 26272 26272
==============================================
Hits 20542 20542
Misses 5730 5730
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Purpose of this PR
This PR does the following updates before 3.0.0 relese:
Jira ticket
N/A
Documentation
N/A
Testing & QA (How your changes can be verified during release Playtest)
Main goal here is to see if Full CI will still be green (expectation)
Up-port
N/A
Backports
N/A