Repository navigation
[NGOv3.X] CI fixes and adjustments - #4163
Conversation
|
Check the configuration's TOML syntax, permitted settings, and size limit. See the error below. Error message: Configuration content:# This is the configuration for the u-pr bot
# https://github.cds.internal.unity3d.com/unity/u-pr
# For configuration of this file:
# https://developer.portal.internal.unity.com/catalog/default/component/u-pr/docs/configuration/automatic_runs/
[github_app]
handle_pr_actions = ['opened', 'ready_for_review'] # PR events that auto-run pr_commands
pr_commands = ["/harness-review"] # what runs on those events
reviewer_commands = ["/harness-review"] # what runs when @u-pr is added as reviewer
|
There was a problem hiding this comment.
💡 Harness Review
The iOS linker postprocessor is correctly scoped to supported iOS builds, and the multiplayer dependency remains consistent across both test manifests and CI workflows.
Reviewed commit a8f9ec1
🤖 Helpful? 👍/👎
jabbacakes
left a comment
There was a problem hiding this comment.
You summoned me with your one line docs change. 👁️ Few small suggestions to polish the tweaks Noel made after my pass in the last PR.
Co-authored-by: Amy Reeve <amy.reeve@unity3d.com>
Co-authored-by: Amy Reeve <amy.reeve@unity3d.com>
Co-authored-by: Amy Reeve <amy.reeve@unity3d.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop-3.x.x #4163 +/- ##
=================================================
+ Coverage 78.01% 78.19% +0.18%
=================================================
Files 153 153
Lines 26260 26272 +12
=================================================
+ Hits 20486 20544 +58
+ Misses 5774 5728 -46
Flags with carried forward coverage won't be shown. Click here to find out more. see 4 files with indirect coverage changes
|
Purpose of this PR
Includes few fixes following on 3.X release which are:
Package Pack (and x-ray) - NGO [win]job"com.unity.services.multiplayer": "2.3.3"to our testproject as that version is compatibleJira ticket
N/A
Documentation
N/A
Testing & QA (How your changes can be verified during release Playtest)
Will run full CI to catch any other issues
Up-port
N/A
Backports
N/A