Repository navigation
Conversation
* fix: Yamato jobs not testing built player * Next round of fixes * Set addressables to build on players * dotnet-fix * Fix console tests * Try again to remove graphics from desktop players * Fix DA NetworkObjectDeserializationFailure test * Remove the temporarily added N4E settings * Fix the test failures * Remove fix that was more a symptom than a cause (keep it simple) * Match the deregistration to the registration logic * Don't finish cleaning up if any scene is still loading * Fix the U-PR config * Fix IL2CPP player tests
![u-pr[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
| commands: | ||
| - unity-downloader-cli --fast --wait -u {{ editor }} -c Editor {% if backend == "il2cpp" %} -c il2cpp {% endif %} | ||
| - UnifiedTestRunner --suite=playmode --platform={{ platform.standalone }} --editor-location=.Editor --testproject={{ project.path }} --scripting-backend={{ backend }} --testfilter="Unity.Netcode.RuntimeTests.*" --player-save-path=build/players --artifacts-path=artifacts --extra-editor-arg=-batchmode --extra-editor-arg=-nographics --reruncount=1 --clean-library-on-rerun --build-only --timeout={{ test_timeout }} | ||
| - unity-downloader-cli --fast --wait -u {{ editor }} -c Editor {% if backend == "il2cpp" %} -c il2cpp {% endif %}{% if backend == "coreclr" %}{% unless coreclr_runtime_editors contains editor %} -c {{ platform.coreclr_component }} {% endunless %}{% endif %} --arch {{ platform.architecture }} |
There was a problem hiding this comment.
Desktop standalone builds fail before testing because the downloader receives --arch without a value. None of the test_platforms.desktop entries in .yamato/project.metafile defines architecture. Consequently, {{ platform.architecture }} renders empty, leaving a bare --arch argument. Both desktop and CMB test jobs depend on these builds, including the Ubuntu IL2CPP jobs triggered for pull requests. Define architecture for every desktop entry, using x64 for Ubuntu and Windows and arm64 for macOS.
🤖 Helpful? 👍/👎
There was a problem hiding this comment.
yeah, that's the cause of failing job but rest looks good
There was a problem hiding this comment.
Was a bad merge! Fixed it now
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop-2.0.0 #4196 +/- ##
=================================================
- Coverage 74.22% 74.20% -0.02%
=================================================
Files 172 172
Lines 28200 28200
=================================================
- Hits 20931 20926 -5
- Misses 7269 7274 +5
Flags with carried forward coverage won't be shown. Click here to find out more. see 2 files with indirect coverage changes
|
This branch has not been deployed
3 participants
Purpose of this PR
Backport of #4194
Jira ticket
n/a
Changelog
Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Up-port
Up-ported by #4194
Backports
The core issue was the CMB tests which don't exist on 1.x. Not sure it's worth backporting this to 1.x