Repository navigation
Fix typos in warning suppression pragma and P2P logs - #456
Open
cramirodehuelbes wants to merge 2 commits into
Open
cramirodehuelbes wants to merge 2 commits into
cramirodehuelbes wants to merge 2 commits into
Conversation
MSVC pragma was misspelled as 'supress', so it would be ignored if used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ANALYZE_SUPPRESS2inminbase_annotations.hspelled the MSVC pragma specifier assupress, so it would be ignored (and MSVC would warn) if used. It only expands in MSVC/analyzebuilds and nothing in this repo uses it, so there’s no runtime impact here. However, the same typo exists insource-sdk-2013/src/public/tier0/annotations.h, which suggests it was inherited from a shared header and could be hit by HL2/TF2 mod devs using the SDK.