Skip to content

fix: ensure domain and range classes are always visible (fixes #172) #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mithunbabbira wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: ensure domain and range classes are always visible (fixes #172) #222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions src/webvowl/js/parser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,34 @@ module.exports = function ( graph ){
// Process the graph data
convertTypesToIris(combinedClassesAndDatatypes, ontologyData.namespace);
convertTypesToIris(combinedProperties, ontologyData.namespace);

// Collect all domain and range references from properties (fix #172)
// Ensure every referenced class has a node even if not declared in the ontology
var referencedClassIds = {};
combinedProperties.forEach(function ( property ) {
if ( property.domain() && typeof property.domain() === "string" ) {
referencedClassIds[property.domain()] = true;
}
if ( property.range() && typeof property.range() === "string" ) {
referencedClassIds[property.range()] = true;
}
});

// Add missing referenced classes as placeholder nodes
var missingClasses = [];
for ( var cid in referencedClassIds ) {
if ( !classMap.hasOwnProperty(cid) ) {
var Placeholder = require("./elements/nodes/implementations/OwlClass");
var missingNode = new Placeholder(graph);
missingNode.id(cid).visible(true);
missingNode.label({ "default": cid });
missingClasses.push(missingNode);
}
}
if ( missingClasses.length > 0 ) {
combinedClassesAndDatatypes = combinedClassesAndDatatypes.concat(missingClasses);
}

nodes = createNodeStructure(combinedClassesAndDatatypes, classMap);
properties = createPropertyStructure(combinedProperties, classMap, propertyMap);
};
Expand Down