Repository navigation
ci: fail the preview step when wrangler fails - #143
Merged
Merged
Conversation
The default run shell has no pipefail, so 'wrangler ... | tee' exited 0 and PR checks stayed green while the upload failed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
rtomas
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Upload previewstep pipeswrangler versions uploadintotee. GitHub's defaultrunshell isbash -ewithoutpipefail, so a wrangler failure exits 0.Example: run 39635806405 (PR #141) logged
Authentication error [code: 10000]but the check was green.Setting
shell: bashon the step makes GitHub usebash --noprofile --norc -eo pipefail. The step now fails when wrangler fails.This PR's own check will fail until the
CLOUDFLARE_API_TOKENsecret holds a valid token. That is the expected result of the fix.🤖 Generated with Claude Code