Skip to content

Docs: Document WP_Http_Cookie properties as nullable - #14182

Closed
rejaulalomkhan wants to merge 1 commit into
WordPress:trunkfrom
rejaulalomkhan:phpstan/retire-boolean-or-always-false
Closed

rejaulalomkhan wants to merge 1 commit into
WordPress:trunkfrom
rejaulalomkhan:phpstan/retire-boolean-or-always-false

Conversation

@rejaulalomkhan

@rejaulalomkhan rejaulalomkhan commented Oct 11, 2026 •

Copy link
Copy Markdown

Description

In WP_Http_Cookie, the $name and $value properties are initialized to null before the constructor sets them. When $data is passed as an associative array without a name key, the constructor returns early, leaving them uninitialized/null. Documenting both as string|null accurately reflects their lifecycle and satisfies PHPStan.

This resolves the sole error in the booleanOr.alwaysFalse baseline, retiring it, and removes two entries from the isset.property baseline.

Follow-up to [63899], [64222].
Trac ticket: https://core.trac.wordpress.org/ticket/65817


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request outside of WordPress Core Trac.

@github-actions

github-actions Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props rejaulalomkhan, huzaifaalmesbah.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

In WP_Http_Cookie, the  and  properties are initialized to null before the constructor sets them. When  is passed as an associative array without a 'name' key, the constructor returns early, leaving them uninitialized/null. Documenting both as string|null accurately reflects their lifecycle and satisfies PHPStan.

This resolves the sole error in the booleanOr.alwaysFalse baseline, retiring it, and removes two entries from the isset.property baseline.

See #65817.
@rejaulalomkhan
rejaulalomkhan force-pushed the phpstan/retire-boolean-or-always-false branch from 7de7999 to b627399 Compare October 11, 2026 04:08
@huzaifaalmesbah

Copy link
Copy Markdown
Member

Thanks for working on this, @rejaulalomkhan!

It looks like this overlaps with #13983, which was opened a few days earlier for the same booleanOr.alwaysFalse baseline. That one also documents $domain as nullable and adds unit tests for the constructor's early return.

To avoid splitting review effort, would you be open to closing this in favour of #13983? A review there would be very welcome.

AI Review: Opus 5.5

@rejaulalomkhan

Copy link
Copy Markdown
Author

Thanks @huzaifaalmesbah. #13983 covers the same baseline, also documents $domain as nullable, and adds tests for the constructor’s early return, so it’s the more complete fix. Closing in favour of #13983

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants