Skip to content

Tests: Verify timezone persistence and restore the original setting #14207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lancewillett wants to merge 3 commits into from
Closed

Tests: Verify timezone persistence and restore the original setting #14207

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e08b2a4
Tests: Verify timezone persistence and restore the original setting
lancewillett Oct 12, 2026
9d6a06c
Build/Test Tools: Preserve stored timezone options in E2E cleanup.
lancewillett Oct 16, 2026
defad98
Tests: Target the browser site when restoring timezone options.
lancewillett Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 51 additions & 4 deletions tests/e2e/specs/general-settings-invalid-timezone.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,59 @@
import { execFileSync } from 'node:child_process';
import { join } from 'node:path';
import { test, expect } from '@wordpress/e2e-test-utils-playwright';

function timezoneOptions( baseURL, values ) {
const restore = values === undefined ? '' : `
$values = json_decode( base64_decode( '${ Buffer.from( JSON.stringify( values ) ).toString( 'base64' ) }' ), true );
foreach ( $values as $option => $value ) {
update_option( $option, $value );
}
`;

return JSON.parse( execFileSync( process.execPath, [
join( process.cwd(), 'tools/local-env/scripts/docker.js' ),
'exec', '--user', 'wp_php', 'cli', 'wp', `--url=${ baseURL }`, 'eval',
`
// Read and restore the stored offset, not the value calculated for a named timezone.
remove_filter( 'pre_option_gmt_offset', 'wp_timezone_override_offset' );
${ restore }
echo wp_json_encode( array(
'timezone_string' => get_option( 'timezone_string' ),
'gmt_offset' => get_option( 'gmt_offset' ),
) );
`,
], { encoding: 'utf-8', env: { ...process.env, DOTENV_CONFIG_QUIET: 'true' } } ) );
}

test.describe( 'Settings -> General', () => {
const invalidTimezones = [ '', '0', 'Barry/Gary' ];
let originalOptions;

test.beforeEach( async ( { admin, baseURL } ) => {
originalOptions = undefined;
originalOptions = timezoneOptions( baseURL );
await admin.visitAdminPage( '/options-general.php' );
} );

test.afterEach( async ( { baseURL } ) => {
if ( originalOptions === undefined ) {
return;
}

// The settings form can normalize stored UTC offsets, so restore the options directly.
expect( timezoneOptions( baseURL, originalOptions ) ).toEqual( originalOptions );
} );

for ( const invalidTimezone of invalidTimezones ) {
test( `Does not allow saving an invalid timezone string with "${invalidTimezone}"`, async ( { admin, page } ) => {
await admin.visitAdminPage( '/options-general.php' );
const validTimezone = originalOptions.timezone_string === 'Europe/Lisbon' ? 'Africa/Libreville' : 'Europe/Lisbon';

// Set the timezone to a valid value.
await page.locator( '#timezone_string' ).evaluate( timezone => timezone.value = 'Europe/Lisbon' );
// Set the timezone to a different valid value.
await page.locator( '#timezone_string' ).selectOption( validTimezone );

// Save changes.
await page.locator( '#submit' ).click();
await expect( page.locator( '#setting-error-settings_updated' ) ).toContainText( 'Settings saved.' );

// Set the timezone to an invalid value.
await page.locator( '#timezone_string' ).evaluate( ( timezone, invalidTimezone ) => {
Expand All @@ -22,7 +64,12 @@ test.describe( 'Settings -> General', () => {
// Save changes.
await page.locator( '#submit' ).click();

await expect( page.locator( '#timezone_string' ) ).toHaveValue( 'Europe/Lisbon' );
await expect( page.locator( '#setting-error-settings_updated' ) ).toContainText( 'The timezone you have entered is not valid. Please select a valid timezone.' );
await expect( page.locator( '#timezone_string' ) ).toHaveValue( validTimezone );

// Verify the saved value on a fresh page, not just the submit response.
await admin.visitAdminPage( '/options-general.php' );
await expect( page.locator( '#timezone_string' ) ).toHaveValue( validTimezone );
} );
}
} );
Loading