Repository navigation
Editor: Add the attachment entity view config for the media editor - #14513
Closed
jorgefilipecosta wants to merge 1 commit into
Closed
jorgefilipecosta wants to merge 1 commit into
jorgefilipecosta wants to merge 1 commit into
Conversation
jorgefilipecosta
marked this pull request as ready for review
October 19, 2026 18:40
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This was referenced Oct 19, 2026
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Adds the view config of the `attachment` post type, whose form is the media editor form. It replaces the default post type form, so the media editor no longer shows only the date and author. Synced from WordPress/gutenberg#84700. See #66229.
jorgefilipecosta
force-pushed
the
update/view-config-server-fields
branch
from
October 19, 2026 19:34
d7b4ec5 to
398116c
Compare
jorgefilipecosta
changed the title
oandregal
reviewed
Oct 19, 2026
wporg-sync
pushed a commit
that referenced
this pull request
Oct 19, 2026
Adds the view config of the `attachment` post type. Its form is the one of the media editor: the editable fields (title, alt text, caption, and description) in a regular layout, then the date, author, file name, MIME type, file size, dimensions, and "Attached to" fields in panels. Only the form is replaced; the default view, the layouts, and the list view stay the ones `wp_get_entity_view_config()` builds for every post type. Without it, the media editor falls back to the default post type form, and the "Details" tab of the "Edit image" modal shows only the date and the author. Developed in #14513. Synced from WordPress/gutenberg#84700. Props jorgefilipecosta, oandregal. See #66229. git-svn-id: https://develop.svn.wordpress.org/trunk@64567 602fd350-edb4-49c9-b593-d223f7449a82
wporg-sync
pushed a commit
to WordPress/WordPress
that referenced
this pull request
Oct 19, 2026
Adds the view config of the `attachment` post type. Its form is the one of the media editor: the editable fields (title, alt text, caption, and description) in a regular layout, then the date, author, file name, MIME type, file size, dimensions, and "Attached to" fields in panels. Only the form is replaced; the default view, the layouts, and the list view stay the ones `wp_get_entity_view_config()` builds for every post type. Without it, the media editor falls back to the default post type form, and the "Details" tab of the "Edit image" modal shows only the date and the author. Developed in WordPress/wordpress-develop#14513. Synced from WordPress/gutenberg#84700. Props jorgefilipecosta, oandregal. See #66229. Built from https://develop.svn.wordpress.org/trunk@64567 git-svn-id: http://core.svn.wordpress.org/trunk@63717 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Member
Author
|
Committed at 388a22f. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the
attachmentview config of WordPress/gutenberg#84700 into the core.This PR adds the view config of the
attachmentpost type: the media editor form (title, alt text, caption and description, then date, author, filename, MIME type, file size, dimensions and "Attached to"). Without it, the media editor modal falls back to the default post type form and its "Details" tab shows only "Date added" and "Author".Some notes:
wp_navigationview config from the same Gutenberg PR is left out: only the Gutenberg navigation list route reads it, and core doesn't ship that route yet.root/siteform, thewp_templatereading_settingsfield and the group summaries of the default post type form are already in core.Testing Instructions
vendor/bin/phpunit --group view-config.Gutenberg PR: WordPress/gutenberg#84700
Trac ticket: https://core.trac.wordpress.org/ticket/66229
Use of AI Tools
AI assistance: Yes
Used for: porting the code and the tests from the Gutenberg PR, and drafting this description; reviewed and edited by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.