Repository navigation
Tests: Add unit test coverage for search feed links - #14519
Open
rejaulalomkhan wants to merge 1 commit into
Open
rejaulalomkhan wants to merge 1 commit into
rejaulalomkhan wants to merge 1 commit into
Conversation
Covers get_search_feed_link() and get_search_comments_feed_link() with plain and pretty permalinks, explicit and default feed types, the default_feed filter, and the search_feed_link filter arguments and return value for both the posts and comments feeds. See #65819.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a test class for
get_search_feed_link()andget_search_comments_feed_link(), which had no tests.The tests cover:
atomfeed, and a query with spaces.feed=comments-<type>with plain permalinks and?withcomments=1with pretty permalinks.default_feedfilter being used when no feed type is passed.search_feed_linkfilter: its arguments ($link,$feed,'posts') and filtered return value for the posts feed, and for the comments feed the two calls it makes (first'posts'for the link it builds on, then'comments') with the filtered return value.Each behaviour was checked against a mutated source (default feed ignored, missing trailing slash, wrong search type, missing
comments-prefix, missingwithcomments, filter result discarded); a test fails for every mutation.This is a test-only change; no production code is modified.
Testing Instructions
npm run test:php -- --filter Tests_Link_GetSearchFeedLinknpm run test:php -- -c tests/phpunit/multisite.xml --filter Tests_Link_GetSearchFeedLinknpm run test:php -- --group link,feedTrac ticket: https://core.trac.wordpress.org/ticket/65819
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Drafting the tests and running the checks. I reviewed the changes, ran the tests locally, and take responsibility for them.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.