Repository navigation
chore: upgrade mocha to 12 and nyc to 18 (DS-3445) - #85
Merged
Merged
Conversation
ikarachristos
added this pull request to stack #84
October 12, 2026 18:50
nikosd23
previously approved these changes
Oct 13, 2026
nikosd23
force-pushed
the
chore/DS-3445-mocha-nyc
branch
from
October 13, 2026 06:16
6ffeb81 to
8573c21
Compare
nikosd23
force-pushed
the
chore/DS-3445-mocha-nyc
branch
from
October 13, 2026 06:19
8573c21 to
5ba6483
Compare
Clears the last Dependabot alerts: serialize-javascript via mocha 11 and uuid via nyc 15's istanbul-lib-processinfo. Both majors only raise the Node floor (mocha ^20.19 || >=22.12, nyc 20 || >=22), which CI's 20.x, 22.x and 24.x matrix already meets. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
nikosd23
force-pushed
the
chore/DS-3445-mocha-nyc
branch
from
October 13, 2026 06:35
5ba6483 to
f486f06
Compare
…-nyc # Conflicts: # package-lock.json # package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Step 3 of DS-3442. Stacked on #83, which is stacked on #82. Merge in order, retargeting each to
master.The last 3 Dependabot alerts come from old transitive versions that only the next majors drop: serialize-javascript (2 alerts, via mocha 11) and uuid 3.4 (via nyc 15's istanbul-lib-processinfo). Both upgrades only change the minimum Node version: mocha 12 needs
^20.19.0 || >=22.12.0and nyc 18 needs20 || >=22. CI's 20.x, 22.x and 24.x matrix already meets both..mocharc.jsand the nyc config need no changes.With #82 and #83, this resolves all 23 open alerts against the lockfile. After this merges, Dependabot PRs #56 and #63 are stale and can be closed.
npm audit still reports 9 findings with no Dependabot alert. They come from tslint (sprintf-js via argparse/js-yaml 3, also pulled in by nyc's config loader) and lint-staged 11 (braces via micromatch). They're dev-only and belong with the optional toolchain step (DS-3446).
Testing
Lint and the full suite on RabbitMQ 3.13.7, run twice: 102 passing both times, the same as master. Coverage is unchanged.
🤖 Generated with Claude Code