Skip to content

fix: handle blank push notification config IDs - #1242

Open
prachisinghal-1 wants to merge 4 commits into
a2aproject:mainfrom
prachisinghal-1:fix-blank-push-config-id
Open

prachisinghal-1 wants to merge 4 commits into
a2aproject:mainfrom
prachisinghal-1:fix-blank-push-config-id

Conversation

@prachisinghal-1

@prachisinghal-1 prachisinghal-1 commented Oct 24, 2026 •

Copy link
Copy Markdown

Description

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Follow the CONTRIBUTING Guide.
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
    • Important Prefixes for release-please:
      • fix: which represents bug fixes, and correlates to a SemVer patch.
      • feat: represents a new feature, and correlates to a SemVer minor.
      • feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
  • Ensure the tests pass
  • Appropriate READMEs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@prachisinghal-1 prachisinghal-1 changed the title Fix blank push notification config ID handling fix: handle blank push notification config IDs Oct 25, 2026
@prachisinghal-1

Copy link
Copy Markdown
Author

The blank push notification config ID changes pass the local module tests. The latest CI run still has one failure on Windows: QuarkusA2AJSONRPC_v0_3_VertxTest.testResubscribeNoExistingTaskError, which times out waiting for the expected error on a nonexistent task. Ubuntu checks pass.

Could you please advise whether this is a known Windows/Vert.x test issue or whether you'd like me to investigate it further?

@kabir kabir left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the Windows test report. The timeout follows an uncaught IllegalStateException: Response already ended at VertxA2AHttpClient.java:456, where the SSE response pipe is created. That prevents the expected error callback from reaching the test.

This appears to be a separate timing-dependent SSE response-handling issue, unrelated to the push-config changes. A rerun fixed it

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants