Repository navigation
fix(server): align builder blocking timeouts with documented defaults - #1249
Merged
Merged
Conversation
Expose timeout overrides for manually wired request handlers and document their configuration. Extend blocking send regression coverage to include artifacts, omitted configuration, and fire-and-forget resubscription. This fixes a2aproject#1247
ehsavoie
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Manually built
DefaultRequestHandlerinstances used blocking timeouts of 5/2/1 seconds instead of the documented 30/5/1 defaults and offered no timeout overrides. Align the builder defaults, expose nonnegative timeout setters, and document how manual wiring differs from CDI configuration.The event delivery race reported in #1247 is already fixed by #1227. Extend that deterministic regression to verify completed tasks include artifacts with both omitted configuration and explicit
returnImmediately=false, and verify fire-and-forget responses still allow resubscription.This fixes #1247