Skip to content

curriculum: add actionable assertion messages to functional7-9 checks - #165

Open
mercael91 wants to merge 7 commits into
abhiksark:devfrom
mercael91:fix/issue-87
Open

mercael91 wants to merge 7 commits into
abhiksark:devfrom
mercael91:fix/issue-87

Conversation

@mercael91

@mercael91 mercael91 commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Closes #87.

Adds beginner-facing messages to all 8 bare assertions named in the issue:

  • checks/functional/functional7.py: 2
  • checks/functional/functional8.py: 2
  • checks/functional/functional9.py: 4

Messages state the expected value (e.g. product of [2, 3, 4] should be 24,
all(x > 0 for x in [1, -2, 3]) should be False: -2 is not > 0) and never
re-call the learner's function, per CONTRIBUTING.md. Every assertion
predicate, side effect and success print is unchanged.

tests/test_functional_assertion_messages.py guards both rules for this batch:
no bare assert in the three files, and no line over 80 columns.

Test output:

$ python -m pytest tests/test_functional_assertion_messages.py -q
4 passed

@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5437b016-7f02-4e40-a0db-b28b841d9160

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…ctional9 checks

Signed-off-by: mercael <mercael91@gmail.com>
…ctional9 checks

Signed-off-by: mercael <mercael91@gmail.com>
…ctional9 checks

Signed-off-by: mercael <mercael91@gmail.com>
…ctional9 checks

Signed-off-by: mercael <mercael91@gmail.com>
@mercael91 mercael91 changed the title Fix #87 curriculum: add actionable assertion messages to functional7-9 checks Oct 23, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant