Repository navigation
test: fix swapped ErrorInfo code/statusCode assertions - #1253
SimonWoolf wants to merge 1 commit into
Conversation
… test #1248 corrected the ErrorInfo argument order; the test had encoded the old swapped values. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe reattach error test now expects error code ChangesChannel error expectations
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Other Merge Risk: ⚪ Minimal · up to
|
#1248 fixed the ErrorInfo constructor argument order for client-side errors (status code before Ably code).
RealtimeChannelTest.channels_get_should_throw_when_would_cause_reattachhad asserted the old swapped values (code == 400,statusCode == 40000), so it has failed on main's Integration Test workflow since #1248 merged. This swaps the assertions tocode == 40000,statusCode == 400.🤖 Generated with Claude Code
Summary by CodeRabbit