Repository navigation
ci_fetch_deps: fetch lib/mp3 and extmod/ulab for zephyr-cp - #11656
Merged
Merged
Conversation
zephyr-cp builds audiomp3 and ulab, but its PORT_DEPS left out both submodules. Board builds only worked when the scheduler job's submodules-common cache restored; with a cold cache they fail on lib/mp3/src/mp3common.h. Fixes adafruit#11655 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11655.
zephyr-cp builds
audiomp3andulab, butPORT_DEPS["zephyr-cp"]left outlib/mp3/andextmod/ulab/. Board jobs only built when the scheduler'ssubmodules-commoncache restored. With that cache missing (evicted, or on a fork), they fail onlib/mp3/src/mp3common.h.🤖 Generated with Claude Code