Repository navigation
Conversation
The MIDI specification lets a Note On with a velocity of zero stand in for a Note Off, and files commonly use it so that a run of notes can share one status byte. MidiTrack ignored velocity entirely, so such a note was started and never stopped, and the voice sounded until the track ended. Read the velocity that was already being parsed and discarded, and release the note when it is zero. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
tyeth
added this pull request to stack #11668
October 23, 2026 22:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third of five stacked PRs; targets the branch of the previous one.
The MIDI specification lets a Note On with a velocity of zero stand in for a Note Off, and files commonly use it so a run of notes can share one status byte.
MidiTrackignored velocity entirely, so such a note was started and never stopped, and the voice sounded until the track ended.Read the velocity that was already being parsed and discarded, and release the note when it is zero.
Verification
Covered by the same cross-check against
adafruit_midi_parser. Builds clean on arm and xtensa.Size
No measurable change — folding the velocity out-parameter into a packed return paid for the added logic.
🤖 Generated with Claude Code