Repository navigation
Conversation
span.dur is a uint16_t, so a delay longer than 65535 samples wrapped: at 44.1kHz that is any gap beyond 1.5 seconds, and a held note or a rest of ordinary length came out far too short. The conversion overflowed too, because delta * sample_rate does not fit in 32 bits for a long delay. Compute the duration in 64 bits and carry whatever does not fit in span.dur in a separate field, handing it over a chunk at a time. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
tyeth
added this pull request to stack #11668
October 23, 2026 22:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fourth of five stacked PRs; targets the branch of the previous one.
span.duris auint16_t, so a delay longer than 65535 samples wrapped. At 44.1kHz that is any gap beyond 1.5 seconds, so a held note or a rest of ordinary length came out far too short. The conversion overflowed too:delta * sample_ratedoes not fit in 32 bits for a long delay.Compute the duration in 64 bits and carry whatever does not fit in
span.durin a separate field, handing it over a chunk at a time.Verification
Builds clean on arm and xtensa. This path is timing-only and was not measured on a device.
Size
About +160 bytes of flash on nrf52840, plus four bytes per
MidiTrackobject.🤖 Generated with Claude Code