Skip to content

espressif/qspibus: mark QSPIBus pins never-reset so the display survives VM cleanup #11670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kccarbone wants to merge 1 commit into
base: main
Choose a base branch
from
Open

espressif/qspibus: mark QSPIBus pins never-reset so the display survives VM cleanup #11670

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ports/espressif/common-hal/qspibus/QSPIBus.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,20 +331,31 @@ void common_hal_qspibus_qspibus_construct(
mp_raise_OSError_msg_varg(MP_ERROR_TEXT("%q failure: %d"), MP_QSTR_QSPI, (int)err);
}

// Mark the bus pins never-reset so they stay attached to the SPI peripheral
// across reset_all_pins() at VM end; the display (e.g. board.DISPLAY) outlives
// the VM. deinit() clears this again via reset_pin_number().
claim_pin(clock);
common_hal_never_reset_pin(clock);
claim_pin(data0);
common_hal_never_reset_pin(data0);
claim_pin(data1);
common_hal_never_reset_pin(data1);
claim_pin(data2);
common_hal_never_reset_pin(data2);
claim_pin(data3);
common_hal_never_reset_pin(data3);
claim_pin(cs);
common_hal_never_reset_pin(cs);
if (dcx != NULL) {
claim_pin(dcx);
common_hal_never_reset_pin(dcx);
gpio_set_direction((gpio_num_t)self->dcx_pin, GPIO_MODE_OUTPUT);
gpio_set_level((gpio_num_t)self->dcx_pin, 1);
}

if (reset != NULL) {
claim_pin(reset);
common_hal_never_reset_pin(reset);

gpio_set_direction((gpio_num_t)self->reset_pin, GPIO_MODE_OUTPUT);
gpio_set_level((gpio_num_t)self->reset_pin, 0);
Expand Down
Loading