Repository navigation
ci(lint): pin golangci-lint and fix issues from v2.15.0 - #91
Merged
Merged
Conversation
The workflow installed golangci-lint `latest`, so new releases started failing main without any code change (since ~2026-08-31), and every open PR inherited the red Lint check. - Pin golangci-lint to v2.15.0. - Disable revive's new marshal-receiver rule: every queue holds a sync mutex, so a value receiver on MarshalJSON would copy the lock. - Remove redundant parentheses in priority.go flagged by newer gofumpt. - Replace the deprecated gofumpt extra-rules setting with extra.group-params and extra.clothe-returns. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 639 550 -89
=========================================
- Hits 639 550 -89
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lint has been red on main since late August because the workflow installs golangci-lint
latest, and newer releases added checks the code didn't pass. Every open PR inherits that failure, including #90. This pins v2.15.0 and fixes what it flags. It disables revive's newmarshal-receiverrule instead of following it, because every queue holds a sync mutex and a value receiver onMarshalJSONwould copy the lock. It also removes redundant parentheses inpriority.gothat gofumpt now rejects, and replaces the deprecated gofumptextra-rulessetting. The trade-off of pinning is that golangci-lint upgrades become a manual version bump, since Dependabot doesn't update the action'sversioninput.Ran golangci-lint v2.15.0 locally (0 issues, no warnings) and
make test-coverage(pass, 100%).