Repository navigation
Normalize repository.url to the form npm publishes - #113
Merged
Merged
Conversation
Contributor
Author
|
Review of 459ebf3. No findings.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sets
repository.urltogit+https://github.com/agentscore/node-sdk.git. npm already rewrites it to that form at publish, which is what the publish log's "npm auto-corrected some errors in your package.json" warning on 2.9.4 reported. The published manifest does not change; the warning goes away from the next release on. pay and node-commerce made the same change in their sweep releases.Worked with: Varun, who asked for the sweep.
Not done: no version bump. This is metadata the next release carries.
Type of change
Public API
None.
Test plan
Manifest-only change. CI runs the full gate set.
Checklist
(no behavior changes; CI runs the suite)
(not run locally for a manifest-metadata change; CI runs them)
(the public surface did not change)