Skip to content

Normalize repository.url to the form npm publishes - #113

Merged
vvillait88 merged 1 commit into
mainfrom
fix/repository-url
Oct 25, 2026
Merged

vvillait88 merged 1 commit into
mainfrom
fix/repository-url

Conversation

@vvillait88

Copy link
Copy Markdown
Contributor

Summary

Sets repository.url to git+https://github.com/agentscore/node-sdk.git. npm already rewrites it to that form at publish, which is what the publish log's "npm auto-corrected some errors in your package.json" warning on 2.9.4 reported. The published manifest does not change; the warning goes away from the next release on. pay and node-commerce made the same change in their sweep releases.

Worked with: Varun, who asked for the sweep.

Not done: no version bump. This is metadata the next release carries.

Type of change

  • Bug fix (no breaking change)
  • New feature (no breaking change)
  • Breaking change (existing callers must update)
  • Docs, tests, or internal maintenance only

Public API

None.

Test plan

Manifest-only change. CI runs the full gate set.

Checklist

  • Tests cover the new behavior, and the suite passes locally
    (no behavior changes; CI runs the suite)
  • Lint, format, and type checks pass
    (not run locally for a manifest-metadata change; CI runs them)
  • Docs and README examples updated if the public surface changed
    (the public surface did not change)
  • No secrets, credentials, or personal data in the diff or the tests

@vvillait88

Copy link
Copy Markdown
Contributor Author

Review of 459ebf3. No findings.

  • Nothing else moves. The diff is one line in package.json, repository.url.

  • The new value is exactly npm's normalization of the old one.

    • I ran npm pkg fix on the base package.json (fetched by the PR's base sha). It produced { type: 'git', url: 'git+https://github.com/agentscore/node-sdk.git' }.
    • That fixed manifest is deep-equal to the head's package.json, with zero differing keys.
    • The registry already serves the same value for the published 2.9.4: npm view @agent-score/sdk@2.9.4 repository returns git+https://github.com/agentscore/node-sdk.git.

    So the published metadata does not change; only the publish-time warning goes away.

  • CI. All 9 checks are green.

@vvillait88
vvillait88 merged commit 7ee4c76 into main Oct 25, 2026
9 checks passed
@vvillait88
vvillait88 deleted the fix/repository-url branch October 25, 2026 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant