Repository navigation
fix(website/ci): build when the previous Vercel commit is unavailable - #832
Merged
Merged
Conversation
vercel-ignore.sh ran git diff against VERCEL_GIT_PREVIOUS_SHA. After a
force-push that commit no longer exists in Vercel's clone, git diff
exits 128 ("fatal: bad object"), and Vercel fails the deployment for
any exit code other than 0/1. Build when the previous commit cannot be
resolved, and map every non-skip outcome to exit 1.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KTj1PEbxzVCETkeYrZKcrE
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Claude finished @ajitpratap0's task in 21s —— View job Review of PR #832
Verdict: LGTM. The fix is correct, small, and targeted. What I checked
Minor, non-blocking suggestions
No bugs found. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
website/scripts/vercel-ignore.sh(added in #821) runsgit diff $VERCEL_GIT_PREVIOUS_SHA HEAD. When a PR branch is force-pushed (a rebase, for example), the previously deployed commit is no longer in Vercel's clone:git diffexits 128 withfatal: bad object <sha>.Observed on #825, #827 and #828 after rebasing them onto
main. Deploymentdpl_8HzjNoKTPk5VJkkKRZW8AgUMyLyxlog:fatal: bad object 5b5aa61e….Changes Made
git cat-file -e), build (exit 1).[vercel skip]behaviour are unchanged.Type of Change
Testing
Exercised every path in a scratch git repo:
[vercel skip]HEAD^)HEAD^bash -npasses.Breaking Changes
None.
🤖 Generated with Claude Code
https://claude.ai/code/session_01KTj1PEbxzVCETkeYrZKcrE