Repository navigation
Sync mendixlabs/mxcli main into ako/mxcli - #1212
Merged
Merged
Conversation
…ssages (mendixlabs#1477) The strings index now holds the documentation of entities, attributes, constants, pages and every other documented element, plus microflow log messages, so SEARCH finds words that appear only there. Both are plain strings, not Texts$Text, which is why the walk that finds the translatable text never saw them. A module's own rows carry the module's name in ModuleName (the objects view holds an empty one for a module). The catalog schema version is 25, so a cached catalog is rebuilt once. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ation fix: search finds words in element documentation and microflow log messages
Brings in mendixlabs#1478 (search finds documentation and log messages). Conflict in CHANGELOG.md [Unreleased] resolved by keeping both the Changed (mendixlabs#1474) and Fixed (mendixlabs#1477) entries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01U6JPskrhXuCjJVz4JRtcdX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Merges mendixlabs/mxcli
maininto this fork so it has every upstream commit. The fork was 2 commits behind, both from mendixlabs#1478:mxcli search/SEARCHfind words that appear only in an element's documentation (entities, attributes, associations, enumerations, constants, pages, …) and in microflow log messages (searchdoes not find words that appear only in an element's documentation (entities, attributes, constants, pages…), and has no exit code to gate on mendixlabs/mxcli#1477). The catalog schema version goes from 24 to 25, so a cached catalog is rebuilt once.Conflict resolution
The only conflict was in
CHANGELOG.md, under[Unreleased]. I kept both sides: the fork's Changed entry (mendixlabs#1474, mxcli no longer creates a module role on its own) and upstream's Fixed entries (mendixlabs#1477). The fork was still at catalog schema version 24, so upstream's change to 25 doesn't collide with anything. This branch also merges cleanly with the currentmain, including the commits added since the sync.Validation
make buildsucceedsgo test ./...passes🤖 Generated with Claude Code
https://claude.ai/code/session_01U6JPskrhXuCjJVz4JRtcdX
Generated by Claude Code