Repository navigation
test: mark each test's steps with Given, When and Then comments - #25
Merged
Merged
Conversation
Every behavioural test now names what it sets up, does and checks, the style test_delivery_implement_scripts.py already used. Calls asserted on the same line are split so the action and the check stand apart. AGENTS.md records the convention for new tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every behavioural test in
tests/unit/now marks its steps with# Given,# Whenand# Thencomments, each followed by a short phrase saying what the step sets up, does or checks. This is the styletest_delivery_implement_scripts.pyalready used; it is now applied across the suite.# Givenis left out when there is nothing to set up.assert launch(...).returncode == OK). They are split intoresult = ...thenassert, so the action and the check stand apart. No assertion changed.AGENTS.mdrecords the convention for new tests.Validation
mise run lint: cleanmise run test: 355 passed