Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Formatting a quoted value containing a backslash followed by LF can remove whitespace and normalize line endings inside that value:
The assertion currently fails: the two spaces after
bdisappear and its CRLF becomes LF.SPLIT_REGEXuses\\.for quoted escapes, but.does not match LF. Enabling DOTALL keeps the complete quoted value together so the serializer only strips whitespace outside it.Added 30 regression cases for single/double quotes, LF/CR/CRLF, paired backslashes, and default/whitespace/reindent formatting. Eight fail before the fix. Independent SQLite checks preserve all 36 tested values after the fix; the original formatter changes eight.
pytest): 536 passed on each of Python 3.12, 3.13 and 3.14; the baseline's two xfails and one xpass are unchangedruff check sqlparse/)