perf(@angular/cli): lazily resolve package manager version to optimize startup - #33902
Closed
alan-agius4 wants to merge 1 commit into
Closed
perf(@angular/cli): lazily resolve package manager version to optimize startup#33902alan-agius4 wants to merge 1 commit into
alan-agius4 wants to merge 1 commit into
Conversation
…e startup Eagerly determining package manager version on every CLI command execution causes a child process spawn (npm/pnpm/yarn/bun --version) on cold start. This change defers version resolution until explicitly needed (e.g. during package operations or version display).
angular-robot
Bot
added
area: performance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
determinePackageManagerandcreatePackageManagereagerly callgetPackageManagerVersionduring command execution startup, spawning child processes (npm --version,pnpm --version,yarn --version,bun --version) on cold starts even when the command does not perform any package manager operations.What is the new behavior?
determinePackageManagerandcreatePackageManagerno longer spawn child processes to query versions during initial command creation.versiongetter onPackageManagerto allow non-blocking version inspection where available.getAnalytics()incommand-module.tsto avoid awaitinggetVersion().Does this PR introduce a breaking change?