Repository navigation
docs: note the removed @angular/platform-server peer in the v21 upgrade guide - #3795
Conversation
…de guide The upgrade guide's "Other notes" already lists the removed @angular/platform-browser-dynamic peer. The optional @angular/platform-server peer is gone too, and apps need no change.
armando-navarro
added
bump: patch
tyler-reitz
left a comment
tyler-reitz
left a comment
There was a problem hiding this comment.
Content looks right, so I am holding the approval rather than giving it, since approval is the only gate here and it would make this mergeable ahead of rc.2. Ping me when rc.2 is ready and I will approve it then.
Two small things while it waits.
The sentence says "peer dependency" twice. Reads better collapsed:
The obsolete
@angular/platform-browser-dynamicand the unused optional@angular/platform-serverpeer dependencies were removed. No action is needed.
And @angular/platform-browser-dynamic is already gone from published 20.1.0, so for anyone upgrading from latest that half of the bullet describes something their current version already did. Worth either saying which removal landed when, or leaving it, since "No action is needed" covers both either way. Your call, it is the sentence this PR happens to touch rather than anything it introduces.
The line said "peer dependency" twice. Naming both packages before one "peer dependencies" reads better.
|
@tyler-reitz This is a draft PR, so an approval doesn't make it mergeable until I pull it out of draft state. If it looks good, could you approve it like you did a previous draft PR I wanted held for a release? It stays a draft until I took your first suggestion, so the line names "peer dependencies" once. I'm leaving the second as it is, since "No action is needed" holds for readers coming from either 20.0.x or 20.1.0. |
tyler-reitz
left a comment
tyler-reitz
left a comment
There was a problem hiding this comment.
Approving while it is still a draft, per the rc.2 hold in the description. The combined note reads correctly coming from either 20.0.x or 20.1.0.
The example named 21.0.0-rc.1, which would install the older release candidate once 21.0.0-rc.2 is out.
…uide 21.0.0-rc.2 skips App Check during server rendering (angular#3773). The guide now says so and links the App Check page's server-rendering section.
2 participants
Refs #3667
Adds the removal of the optional
@angular/platform-serverpeer (#3792) to the "Other notes" list indocs/version-21-upgrade.md, next to the existing note about@angular/platform-browser-dynamic.