Repository navigation
Conversation
d401ce8 to
301277e
Compare
|
hold on this one until #40396 is merged |
301277e to
7e10f74
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #40023 +/- ##
============================================
+ Coverage 56.16% 58.85% +2.68%
- Complexity 2288 13997 +11709
============================================
Files 1124 2595 +1471
Lines 178336 272794 +94458
Branches 1489 11316 +9827
============================================
+ Hits 100170 160548 +60378
- Misses 75645 106214 +30569
- Partials 2521 6032 +3511
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…_readFromkafkaIssue#35186
…_readFromkafkaIssue#35186
…_readFromkafkaIssue#35186
|
/gemini review |
There was a problem hiding this comment.
📋 Review Summary
This PR resolves issue #35186 by enabling YAML map and list structures to be serialized into JSON strings when mapped to a STRING schema field in both Java (YamlUtils) and Python (ExplicitSchemaTransformPayloadBuilder). This allows users to specify inline structured schemas (e.g., JSON or Avro schemas) in ReadFromKafka and WriteToKafka YAML configurations without needing to format them as literal YAML block strings.
🔍 General Feedback
- The implementation in both Java and Python is clean, idiomatic, and consistent across both SDKs.
- Unit and integration test coverage is thorough, covering
YamlUtils,ExplicitSchemaTransformPayloadBuilder,ManagedKafka transforms, and end-to-end YAML pipeline expansion.
💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.
|
Assigning reviewers: R: @chamikaramj for label yaml. This pull request likely touches a core component ("core" label). Please review with scrutiny. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
fixes #35186
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.