Repository navigation
Conversation
There was a problem hiding this comment.
📋 Review Summary
This PR updates DeltaWriteTestUtils.java to use pattern matching for instanceof (val instanceof java.time.Instant inst), resolving the PatternMatchingInstanceof ErrorProne check failure on Java 17+ builds that caused the Release Nightly Snapshot workflow to fail.
🔍 General Feedback
- The change is clean, minimal, and valid since
:sdks:java:io:deltaexplicitly requires Java 17 (requireJavaVersion: JavaVersion.VERSION_17).
💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40668 +/- ##
=============================================
- Coverage 56.16% 0 -56.17%
=============================================
Files 1124 0 -1124
Lines 178336 0 -178336
Branches 1489 0 -1489
=============================================
- Hits 100170 0 -100170
+ Misses 75645 0 -75645
+ Partials 2521 0 -2521
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
* Suppress PatternMatchingInstanceof in DeltaLakeIO test
b3c50cb to
208f50c
Compare
|
Assigning reviewers: R: @ahmedabu98 for label delta. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Fix #38899
R: @aIbrahiim