Repository navigation
Support RSS trimming for idle bthread stacks - #3668
Open
chenBright wants to merge 1 commit into
Open
chenBright wants to merge 1 commit into
chenBright wants to merge 1 commit into
Conversation
chenBright
force-pushed
the
bthread_stack_trim_simple
branch
from
October 26, 2026 13:45
31f182e to
c8d4e9a
Compare
chenBright
force-pushed
the
bthread_stack_trim_simple
branch
from
October 26, 2026 15:38
c8d4e9a to
42afe63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: resolve
Problem Summary:
Traffic spikes can leave tens of thousands of bthread stacks cached in ObjectPool.
After concurrency drops, their resident pages remain allocated, keeping process
RSS high even when only a few hundred stacks are needed.
What is changed and the side effects?
Changed:
process_idle_objectsAPI to ObjectPool. It processes idleglobal chunks outside the pool lock and retains processed chunks for reuse
after regular free chunks.
MADV_DONTNEED,preserving and guard pages. Rebuild the context on reuse, including after partial
reclamation failures.
expose the
bthread_stack_trimmed_countmetric.Single-run measurements with 50,000 stacks and 8 workers showed the following
process RSS changes after synchronous trimming:
Side effects:
Performance effects:
Breaking backward compatibility:
Check List: