Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
3 open issues
ExtendedEndPoint::address(ep)is called unconditionally. In the surrounding codebase (e.g.,… · New Comparingendpoint2str(ep)to the original input string can be overly strict ifendpoint2str… · New Asserting the refcount is exactly1is brittle: the initial refcount for an extended endpoint may… · New
What changed in this PR
Fixes butil::EndPoint self-assignment so it doesn’t accidentally clear extended endpoints (because reset() mutates shared state), and adds regression coverage for common address types.
Changes:
- Add an early-return guard in
EndPoint::operator=forthis == &rhs. - Add a regression unit test covering self-assignment for IPv4, IPv6, and Unix socket endpoints.
| File | Description |
|---|---|
| test/endpoint_unittest.cpp | Adds a regression test to ensure self-assignment preserves endpoint value and extended storage. |
| src/butil/endpoint.cpp | Prevents reset() from running on self-assignment by adding an early return. |
Review effort: Lite
Copilot stopped reviewing on behalf of
chenBright due to an error
October 26, 2026 14:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What problem does this PR solve?
Issue Number: resolve
Problem Summary:
EndPointbecausereset()also modifies the source object.What is changed and the side effects?
Changed:
Side effects:
Performance effects: One pointer comparison per assignment.
Breaking backward compatibility: None.
Breaking backward compatibility:
Check List: