Repository navigation
Fix semaphore wakeup count to match posted permits - #3673
Open
chenBright wants to merge 2 commits into
Open
chenBright wants to merge 2 commits into
chenBright wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new tests can miscount queued pthread wakeups and fail despite correct semaphore behavior.
1 open issue
What changed in this PR
This PR addresses #3672 by making semaphore posts wake waiters according to newly posted permits rather than the previous semaphore count, avoiding unnecessary wakeups under contention.
Changes:
- Pass the posted permit count to
butex_wake_n. - Add regression tests for single-permit, batch, and zero-permit posts across different initial counts.
| File | Description |
|---|---|
test/bthread_semaphore_unittest.cpp |
Adds wake-count regression tests using bthread and pthread waiters. |
src/bthread/semaphore.cpp |
Corrects the wake limit and removes the unused previous count. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What problem does this PR solve?
Issue Number: resolve #3672
Problem Summary:
What is changed and the side effects?
Changed:
Side effects:
Performance effects:
Breaking backward compatibility:
Check List: