feat: load policy with a single LRANGE instead of one LINDEX per rule

casbin_redis_adapter/adapter.py

@@ -73,9 +73,9 @@ def load_policy(self, model):
             model (CasbinRule): CasbinRule object
         """
 
-        length = self.client.llen(self.key)
-        for i in range(length):
-            line = self.client.lindex(self.key, i)
+        # Fetch the whole list with a single LRANGE: one round trip instead of
+        # one LINDEX per rule, and an atomic snapshot of the list.
+        for line in self.client.lrange(self.key, 0, -1):
             line = json.loads(line)
             rule = CasbinRule(**line)
             persist.load_policy_line(str(rule), model)

tests/test_adapter.py

@@ -2,6 +2,7 @@
 from casbin_redis_adapter.adapter import CasbinRule
 
 from unittest import TestCase
+from unittest import mock
 import redis
 import casbin
 import os
@@ -71,6 +72,24 @@ def test_enforcer_basic(self):
         self.assertTrue(e.enforce("alice", "data2", "read"))
         self.assertTrue(e.enforce("alice", "data2", "write"))
 
+    def test_load_policy_single_round_trip(self):
+        """
+        test load_policy reads all rules with one LRANGE, not one LINDEX per rule
+        """
+        e = get_enforcer()
+        adapter = e.get_adapter()
+        with mock.patch.object(
+            adapter.client, "lrange", wraps=adapter.client.lrange
+        ) as lrange, mock.patch.object(
+            adapter.client, "lindex", side_effect=AssertionError("LINDEX used")
+        ):
+            e.load_policy()
+        lrange.assert_called_once_with("casbin_rules", 0, -1)
+        self.assertEqual(len(e.get_policy()), 4)
+        self.assertEqual(len(e.get_grouping_policy()), 1)
+        self.assertTrue(e.enforce("alice", "data1", "read"))
+        self.assertTrue(e.enforce("alice", "data2", "write"))
+
     def test_add_policy(self):
         """
         test add_policy