test: fix smoke test failures on xen/vmware - #13628
Conversation
boring-cyborg
Bot
added
component:integration-test
Python
|
@blueorangutan package |
|
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
There was a problem hiding this comment.
Pull request overview
This PR targets integration smoke test stability across hypervisors (notably XenServer/XCP-ng and VMware) by skipping KVM-specific checks/tests when not running on KVM, and by adjusting a few timing/host prerequisite assumptions that can cause intermittent failures.
Changes:
- Skip KVM-only paths in smoke tests when the detected hypervisor is not KVM.
- Add additional host-tool prerequisite checks for a VPC source NAT IP update test.
- Add delays around affinity-group migration steps and make the events-resource test more tolerant around volume attach/detach operations.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| test/integration/smoke/test_nonstrict_affinity_group.py | Adds waits before migration steps in non-strict affinity group tests. |
| test/integration/smoke/test_network_extension_namespace.py | Skips KVM prerequisite checks on non-KVM hypervisors; expands required host tools for one test. |
| test/integration/smoke/test_kms_lifecycle.py | Skips a VM root-disk encryption test on non-KVM hypervisors. |
| test/integration/smoke/test_events_resource.py | Wraps volume attach/detach operations to avoid hard failures in some environments. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13628 +/- ##
=========================================
Coverage 19.72% 19.73%
- Complexity 19941 19946 +5
=========================================
Files 6371 6371
Lines 575738 575742 +4
Branches 70471 70473 +2
=========================================
+ Hits 113582 113609 +27
+ Misses 449810 449784 -26
- Partials 12346 12349 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18593 |
|
@blueorangutan test ubuntu26 xcpng82 keepEnv |
|
@weizhouapache a [SL] Trillian-Jenkins test job (ubuntu26 mgmt + xcpng82) has been kicked to run smoke tests |
|
@blueorangutan test ubuntu26 vmware-80u3e keepEnv |
|
@weizhouapache a [SL] Trillian-Jenkins test job (ubuntu26 mgmt + vmware-80u3e) has been kicked to run smoke tests |
|
@blueorangutan package |
|
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18602 |
|
@blueorangutan test ubuntu26 xcpng82 |
|
@weizhouapache a [SL] Trillian-Jenkins test job (ubuntu26 mgmt + xcpng82) has been kicked to run smoke tests |
|
@blueorangutan test ubuntu26 vmware-80u3e |
|
@weizhouapache a [SL] Trillian-Jenkins test job (ubuntu26 mgmt + vmware-80u3e) has been kicked to run smoke tests |
|
[SF] Trillian Build Failed (tid-7) |
|
@blueorangutan test ubuntu26 vmware-80u3 |
|
@weizhouapache a [SL] Trillian-Jenkins test job (ubuntu26 mgmt + vmware-80u3) has been kicked to run smoke tests |
|
[SF] Trillian Build Failed (tid-9) |
|
[SF] Trillian Build Failed (tid-19) |
|
[SF] Trillian Build Failed (tid-20) |
|
[SF] Trillian test result (tid-17)
|
|
[SF] Trillian test result (tid-16696)
|
|
[SF] Trillian test result (tid-23)
|
|
moving to 4.22.2 milestone as it fixes smoke tests, not functionalities |
|
[SF] Trillian test result (tid-25)
|
does it still need rebasing on 4.22, @weizhouapache ? |
Yes |
a6abcce to
440ca34
Compare
|
@blueorangutan package |
|
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.
Suppressed comments (1)
test/integration/smoke/test_usage.py:1756
PublicIPAddress.list(...)can returnNone/an empty list (e.g., source-NAT IP not allocated yet or eventual consistency). Indexingsrc_nat_list[0]will then raiseTypeError/IndexError, making the test flaky. Add a short retry + explicit failure message before selecting the first result.
domainid=cls.virtual_machine.domainid,
issourcenat=True
)
cls.public_ip = src_nat_list[0]
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18953 |
|
@blueorangutan test matrix |
|
@weizhouapache a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-16803)
|
|
[SF] Trillian test result (tid-16805)
|
|
[SF] Trillian test result (tid-16806)
|
|
[SF] Trillian test result (tid-16804)
|
Description
This PR fixes some smoke test failures on vmware or xenserver/xcpng
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?