Skip to content

config cleanup - #13884

Draft
DaanHoogland wants to merge 48 commits into
mainfrom
ghi10752-configCleanup
Draft

config cleanup#13884
DaanHoogland wants to merge 48 commits into
mainfrom
ghi10752-configCleanup

Merge branch 'main' into ghi10752-configCleanup

826a7b9
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Aug 22, 2026 in 7m 2s

Quality Gate failed

Failed conditions
26.3% Coverage on New Code (required ≥ 40%)
C Reliability Rating on New Code (required ≥ B)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 3510 in server/src/main/java/com/cloud/user/AccountManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a primitive boolean expression here. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAKNg3S3ej0ChNocDo2&open=AaAKNg3S3ej0ChNocDo2&pullRequest=13884

Check warning on line 149 in server/src/main/java/com/cloud/alert/AlertManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the "_publicIPCapacityThreshold" field and declare it as a local variable in the relevant methods. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAFdWG4qJXQQ7HDE9SH&open=AaAFdWG4qJXQQ7HDE9SH&pullRequest=13884

Check warning on line 2078 in server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a primitive boolean expression here. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAKNgTE3ej0ChNocDo1&open=AaAKNgTE3ej0ChNocDo1&pullRequest=13884

Check failure on line 35 in plugins/network-elements/elastic-loadbalancer/src/main/java/com/cloud/network/lb/ElasticLoadBalancerManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Advanced" 4 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAHqtW-RdE24u2TNGQJ&open=AaAHqtW-RdE24u2TNGQJ&pullRequest=13884

Check warning on line 152 in server/src/main/java/com/cloud/alert/AlertManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the "_vlanCapacityThreshold" field and declare it as a local variable in the relevant methods. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAFdWG4qJXQQ7HDE9SJ&open=AaAFdWG4qJXQQ7HDE9SJ&pullRequest=13884

Check failure on line 31 in api/src/main/java/com/cloud/network/NetworkUsageService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Usage" 3 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAFdVuaqJXQQ7HDE9R5&open=AaAFdVuaqJXQQ7HDE9R5&pullRequest=13884

Check warning on line 150 in server/src/main/java/com/cloud/alert/AlertManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the "_privateIPCapacityThreshold" field and declare it as a local variable in the relevant methods. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAFdWG4qJXQQ7HDE9SG&open=AaAFdWG4qJXQQ7HDE9SG&pullRequest=13884

Check warning on line 120 in server/src/main/java/com/cloud/network/ExternalFirewallDeviceManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Split this “Monster Class” into smaller and more specialized ones to reduce its dependencies on other classes from 31 to the maximum authorized 20 or less. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAHquAoRdE24u2TNGQL&open=AaAHquAoRdE24u2TNGQL&pullRequest=13884

Check failure on line 30 in api/src/main/java/org/apache/cloudstack/usage/UsageService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Usage" 6 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAFdVtkqJXQQ7HDE9R3&open=AaAFdVtkqJXQQ7HDE9R3&pullRequest=13884

Check warning on line 50 in server/src/test/java/com/cloud/resource/DiscovererBaseTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAPZ2ubGw8sSOR9q8QZ&open=AaAPZ2ubGw8sSOR9q8QZ&pullRequest=13884

Check failure on line 276 in server/src/main/java/com/cloud/server/StatsCollector.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "60000" 5 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAHMU2cH6sOtJrG0c_b&open=AaAHMU2cH6sOtJrG0c_b&pullRequest=13884

Check warning on line 2510 in server/src/test/java/com/cloud/server/ManagementServerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "verify". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAPZ2qNGw8sSOR9q8QR&open=AaAPZ2qNGw8sSOR9q8QR&pullRequest=13884

Check warning on line 49 in server/src/test/java/com/cloud/resource/DiscovererBaseTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAPZ2ubGw8sSOR9q8QY&open=AaAPZ2ubGw8sSOR9q8QY&pullRequest=13884

Check failure on line 97 in api/src/main/java/com/cloud/network/NetworkService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Hidden" 5 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAFdVvZqJXQQ7HDE9R6&open=AaAFdVvZqJXQQ7HDE9R6&pullRequest=13884

Check failure on line 893 in server/src/main/java/com/cloud/network/NetworkServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 32 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAHMUnuH6sOtJrG0c_a&open=AaAHMUnuH6sOtJrG0c_a&pullRequest=13884

Check failure on line 39 in server/src/main/java/com/cloud/server/ManagementServer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Advanced" 37 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAHquINRdE24u2TNGQP&open=AaAHquINRdE24u2TNGQP&pullRequest=13884

Check failure on line 26 in server/src/main/java/com/cloud/projects/ProjectManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "false" 3 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAFdWJnqJXQQ7HDE9SK&open=AaAFdWJnqJXQQ7HDE9SK&pullRequest=13884

Check failure on line 31 in engine/components-api/src/main/java/com/cloud/vm/snapshot/VMSnapshotManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Advanced" 3 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAHMT2AH6sOtJrG0c_V&open=AaAHMT2AH6sOtJrG0c_V&pullRequest=13884

Check failure on line 75 in server/src/main/java/com/cloud/projects/ProjectManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename method "projectInviteRequired" to prevent any misunderstanding/clash with field "ProjectInviteRequired". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAFdWJnqJXQQ7HDE9SM&open=AaAFdWJnqJXQQ7HDE9SM&pullRequest=13884

Check warning on line 882 in server/src/test/java/com/cloud/configuration/ConfigurationManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "doReturn". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAGbHxQTV2yRQvmzXM2&open=AaAGbHxQTV2yRQvmzXM2&pullRequest=13884

Check failure on line 39 in api/src/main/java/com/cloud/user/ResourceLimitService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Project Defaults" 12 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAFdVv5qJXQQ7HDE9R8&open=AaAFdVv5qJXQQ7HDE9R8&pullRequest=13884

Check failure on line 25 in engine/api/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/StorageCacheManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Storage" 3 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAFdVpfqJXQQ7HDE9R1&open=AaAFdVpfqJXQQ7HDE9R1&pullRequest=13884

Check failure on line 38 in engine/components-api/src/main/java/com/cloud/network/security/SecurityGroupManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Network" 4 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAFdVstqJXQQ7HDE9R2&open=AaAFdVstqJXQQ7HDE9R2&pullRequest=13884

Check failure on line 131 in server/src/main/java/com/cloud/usage/UsageServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename field "usageExecutionTimeZone" to prevent any misunderstanding/clash with field "UsageExecutionTimezone" defined in interface "org.apache.cloudstack.usage.UsageService". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAFdWETqJXQQ7HDE9SD&open=AaAFdWETqJXQQ7HDE9SD&pullRequest=13884

Check failure on line 87 in api/src/main/java/com/cloud/network/NetworkService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Network" 3 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAHMUAhH6sOtJrG0c_Z&open=AaAHMUAhH6sOtJrG0c_Z&pullRequest=13884
View more details on SonarQubeCloud