ui: show related settings when (main) config value is changed - #13965
Open
shwstppr wants to merge 1 commit into
Open
ui: show related settings when (main) config value is changed#13965shwstppr wants to merge 1 commit into
shwstppr wants to merge 1 commit into
Conversation
For many CloudStack feature there is a main boolean config which controls whether the feature is enabled or not. When such configs are changed it may be useful for user to update related configurations for the feature. This UI change shows those related settings using the changed config name. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the CloudStack UI configuration editor to prompt administrators with a list of “related settings” after a main (boolean) global configuration is changed, making it easier to review/update dependent settings from the same screen.
Changes:
- Add a related-settings modal to
ConfigurationValuethat fetches and displays configs sharing the changed config’s prefix. - Add logic to derive a related-config prefix and call
listConfigurationsto populate the modal. - Add new English locale strings for the modal title and prompt message.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| ui/src/views/setting/ConfigurationValue.vue | Adds related-settings modal UI, prefix derivation, and API call to fetch/display related configuration entries. |
| ui/public/locales/en.json | Adds i18n strings for the related-settings modal title and prompt message. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+193
to
+200
| <a-modal | ||
| v-if="!suppressRelatedPrompt" | ||
| v-model:visible="relatedModalVisible" | ||
| :title="$t('label.related.settings')" | ||
| :footer="null" | ||
| :maskClosable="false" | ||
| :width="'60vw'" | ||
| @cancel="closeRelatedModal"> |
Comment on lines
+403
to
+408
| const params = { | ||
| [this.scopeKey]: this.$route.params?.id, | ||
| keyword: prefix, | ||
| pagesize: -1, | ||
| listAll: true | ||
| } |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13965 +/- ##
=========================================
Coverage 19.73% 19.73%
- Complexity 19956 19958 +2
=========================================
Files 6371 6371
Lines 575765 575822 +57
Branches 70478 70492 +14
=========================================
+ Hits 113642 113655 +13
- Misses 449766 449816 +50
+ Partials 12357 12351 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For many CloudStack feature there is a main boolean config which controls whether the feature is enabled or not. When such configs are changed it may be useful for user to update related configurations for the feature. This UI change shows those related settings using the changed config name.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
UI-Config-Related.mp4
How Has This Been Tested?
How did you try to break this feature and the system with this change?