Repository navigation
SQLite: Reject colon-based semi-structured data traversal - #2613
Open
LucaCappelletti94 wants to merge 4 commits into
Open
LucaCappelletti94 wants to merge 4 commits into
LucaCappelletti94 wants to merge 4 commits into
Conversation
LucaCappelletti94
added
bug
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2613 +/- ##
=======================================
Coverage 81.99% 82.00%
=======================================
Files 42 42
Lines 35049 35050 +1
Branches 35049 35050 +1
=======================================
+ Hits 28740 28741 +1
Misses 2744 2744
Partials 3565 3565 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
LucaCappelletti94
marked this pull request as ready for review
October 5, 2026 19:08
LucaCappelletti94
force-pushed
the
upstream/sqlite-postfix-colon
branch
2 times, most recently
from
October 18, 2026 14:24
a0425ba to
e30f8ff
Compare
sabir-akhadov-localstack
left a comment
sabir-akhadov-localstack
left a comment
Contributor
There was a problem hiding this comment.
Conflicts with main: #2683 added get_next_precedence to this impl (&/| arm) and parse_unterminated_block_comment lands at the same spot in the test file; needs a rebase.
| None | ||
| } | ||
|
|
||
| fn get_next_precedence(&self, parser: &Parser) -> Option<Result<u8, ParserError>> { |
Contributor
Contributor
Author
Please do not add review notes on rebases, those are pretty evident by themselves. |
LucaCappelletti94
force-pushed
the
upstream/sqlite-postfix-colon
branch
5 times, most recently
from
October 24, 2026 14:06
9aa2315 to
add1eeb
Compare
LucaCappelletti94
force-pushed
the
upstream/sqlite-postfix-colon
branch
from
October 24, 2026 14:25
add1eeb to
306917e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQLiteDialectparsesSELECT c:seas aJsonAccessexpression, the same:semi-structured traversal Snowflake and Databricks use. Real SQLite rejects it:near ":se": syntax error.SQLiteDialectnow overridesget_next_precedenceforToken::Colon, the same pattern PostgreSqlDialect and MsSqlDialect already use, so:never starts an infix parse there. Named parameters,::casts, and->/->>are unaffected.