[LucaCappelletti94]

A BigQuery identifier without quotes that ends in a number, such as foo-123, had to be followed by whitespace or end of input. SELECT * FROM foo-1, bar-2 therefore failed with whitespace following hyphenated identifier, even though the comma is clearly not part of the name. The parser now peeks at the next token instead of consuming it and only rejects a word or number butted directly onto the trailing number, the case that would glue into the identifier as in foo-123a and is still rejected. Any other token, such as a comma, parenthesis, or keyword, may now follow the numeric segment.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.00%. Comparing base (594bb04) to head (a907231).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2620   +/-   ##
=======================================
  Coverage   81.99%   82.00%           
=======================================
  Files          42       42           
  Lines       35049    35050    +1     
  Branches    35049    35050    +1     
=======================================
+ Hits        28740    28741    +1     
  Misses       2744     2744           
  Partials     3565     3565           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[s5dsn-eqee]

Looks good. Please add a few more tests and a fuzz seed.

Test example:

// Punctuation butted onto the trailing number is fine.
bigquery().one_statement_parses_to("SELECT * FROM foo-1;", "SELECT * FROM foo-1");
bigquery().verified_stmt("SELECT * FROM (SELECT 1 FROM foo-1)");
bigquery().one_statement_parses_to("CREATE TABLE t-1(a INT64)", "CREATE TABLE t-1 (a INT64)");

// A quoted word glued onto the number is rejected like a bare word.
let err = bigquery()
    .parse_sql_statements("SELECT * FROM foo-1`x`")
    .unwrap_err();
assert_eq!(
    ParserError::ParserError(
        "Expected: whitespace following hyphenated identifier, found: `x`".to_string(),
    ),
    err
);

[s5dsn-eqee]

👍

[LucaCappelletti94]

Added the tests and seed

[s5dsn-eqee]

LGTM!

[sabir-akhadov-localstack]

One non-blocking comment inline.

[sabir-akhadov-localstack]

foox and `foo-bar`x parse with alias x on main and here, so pinning foo-1x`` as an error is inconsistent; a quoted word cannot glue into the identifier, so Token::Word(Word { quote_style: None, .. }) would make the numeric segment behave like the word segment.

[LucaCappelletti94]

Added red tests and fixed