Repository navigation
HBASE-30363 Migrate AdaptiveLRU to LruCacheEngine and adaptive policy - #8766
Open
VladRodionov wants to merge 1 commit into
Open
VladRodionov wants to merge 1 commit into
VladRodionov wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the native CacheAccessService path for AdaptiveLRU from
LruAdaptiveBlockCachetoLruCacheEngineplus a dedicated adaptiveplacement/admission policy.
The legacy
BlockCacheconstruction path remains unchanged.Changes
AdaptiveLruCachePlacementAdmissionPolicy.CacheEvictionListener.CachePlacementAdmissionPolicy.LruCacheEnginereport requested eviction pressure (bytesToFree).TopologyBackedCacheAccessServiceroute:CacheTopology;CachePlacementAdmissionPolicy.LruCacheEnginefor AdaptiveLRU in the CacheAccessService path.LruAdaptiveBlockCachefor the legacyBlockCacheFactoryconstruction path.
AdaptiveLRU behavior
The adaptive algorithm preserves the behavior of the legacy
LruAdaptiveBlockCache, including:For tiered caches, AdaptiveLRU controls L1 admission only. It does not
globally reject a block that can still be placed in L2.
Tests
Adds coverage for:
LruCacheEngine;TopologyBackedCacheAccessService;LruAdaptiveBlockCacheconstruction path.